fix submitMove pref - closes #13237

lichess-org · Jul 18, 2023 · 741d5a0 · 741d5a0
1 parent 43b2001
commit 741d5a0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 6 deletions.
diff --git a/app/views/account/bits.scala b/app/views/account/bits.scala
@@ -71,8 +71,7 @@ object bits:
               st.id := id,
               checked option st.checked,
               tpe      := "checkbox",
-              st.value := key.toString,
-              name     := field.name
+              st.value := key.toString
             ),
             label(`for` := id)(value)
           )

diff --git a/ui/site/src/account.ts b/ui/site/src/account.ts
@@ -21,7 +21,7 @@ lichess.load.then(() => {
       $form = $(form),
       showSaved = () => $form.find('.saved').removeClass('none');
     $form.find('input').on('change', function (this: HTMLInputElement) {
-      if (this.name == 'behavior.submitMove') submitMoveChoices(this);
+      submitMoveChoices('behavior.submitMove');
       localPrefs.forEach(([categ, name, storeKey]) => {
         if (this.name == `${categ}.${name}`) {
           lichess.storage.boolean(storeKey).set(this.value == '1');
@@ -60,10 +60,10 @@ lichess.load.then(() => {
   });
 });
 
-function submitMoveChoices(input: HTMLInputElement) {
+function submitMoveChoices(name: string) {
   let sum = 0;
-  $(`input[type="checkbox"][name="${input.name}"]:checked`).each(function (this: HTMLInputElement) {
+  $(`input[type="checkbox"][data-name="${name}"]:checked`).each(function (this: HTMLInputElement) {
     sum |= parseInt(this.value);
   });
-  $(`input[type="hidden"][name="${input.name}"]`).val(sum.toString());
+  $(`input[type="hidden"][name="${name}"]`).val(sum.toString());
 }