Site refactor #52

olizilla · 2017-06-12T15:05:30Z

This list may grow, but this is the story as best we know it right now.

- Pull head and footer to partials - Use hugo builtin GA template - Add package.json. Subsequent PR will clean up StandardJS warnings.

- Removes rogue index.css link from common head.html patial. - Fix line endings in README.md. - Simplify .gitignore to only contain file types this project might generate.

olizilla · 2017-06-12T15:07:23Z

@diasdavid this is mergable if you have a moment to review. I'm working on fixing up the JS so there are no standard errors next.

- Use factor-bundle to create page specific bundles pull common deps into common.js

daviddias · 2017-06-13T00:40:54Z

README.md

+
+## Implementations & Bundles
+
+JSON arrays to update implementation & bundle status can be found in `/static/js/data`


Documentation needs to be updated as in "how to update the JSON arrays and what are they containing"

👍 the README will be fixed up to comply with the README spec, but I'll tackle that last once everything is in place.

daviddias · 2017-06-13T00:41:39Z

README.md

+> hugo
+# ..
+
+> ipfs add -r public


Should also explain how to use the DNS simple publish script

@lgierth can we create a test account for tableflip? A simple account with a random domain will do, then all we need is to change the target and API token.

My crappy dnslink script is here: https://github.com/ipfs/infrastructure/blob/master/scripts/dnslink.sh

It needs bash, curl, jq (all in homebrew), and you call it like this DNSIMPLE_TOKEN=<token> ./dnslink.sh <domain> <hash>

daviddias · 2017-06-13T00:42:50Z

content/bundles.html

+        <div class="triangle grey"></div>
+    </article>
+
+</main>


Only the main should be in body. Anything that is template/design should go into a partials/template folder.

I will be pulling much more into partials.

When building pages I find it most useful to be able to compose the page out of templates, rather than override things from a layout. A layout either ends up encoding some assumptions, that some pages may not want, or is so thin that it's hardly worth making the dev fit 2 files in there head to guess what the resulting page will be.

daviddias · 2017-06-13T00:46:48Z

Good progress here! :)

Since there is more to follow, could you list the items you have in mind with check boxes (example) so that I pointing something you already have in mind? Thank you!

olizilla · 2017-06-13T08:02:40Z

~~Taa, much more to follow. If you're happy with this so far, then I'd say let's merge it, and I'll make a checklist for the next one.~~

- Pull data into json and into hugo data folder. Next step, static build all the things. - Decompose common.js into named modules with a single purpose, to ease maintenance. - Fix process to create page specific and common JS bundles. - Add build:* and watch* scripts to package.json

olizilla · 2017-06-13T15:28:37Z

I've update the PR description to show our progress. The list will grow as the points still to do become more clear as I fix things up, but it's a good start. I'm going to fold all my subsequent branches into this PR.

Browserify

Pull the topbar into a partial

Data driven impls

- Port JS UI code to hugo partial bundle.html - Add coming soon section

Data driven bundles

Pull in contributors data at build time

olizilla · 2017-06-20T17:02:25Z

@diasdavid I'll be working on the build / minify / deploy process and README updates tomorrow. PR is good for your eyeballs now though.

daviddias · 2017-06-21T13:56:17Z

Hey Tableflip! Here is my preliminary review as I test this new hawt 🔥 iteration on the website.

package.json needs to be updated
- remove unnecessary deps
- remove non used npm scripts
- make sure that whatever is needed to build the website is part of the Markefile

I've reviewed the website on a train and I've experienced how slow it is to fetch every single image on the contributors graph over a tethered connection

Can you make the fetch of those images happen in build step + the crop (less space used), so that the users had to load less content.

Still on the Contributors graph, the horizonal scroll is not working for me now.

This got busted

Tiny request: Can we have the implementations.json be one .json per table? It gets exhausting to have to scroll so much.

Let's have anything related with the structure of the website, be inside the layouts folder. By that I mean the js and less into layouts

What's is the difference between the js inside js and the js inside static/js? Looks like there is no transpilation/bundling step, everything can just live in the static/js folder.

daviddias · 2017-06-21T14:00:24Z

This is it for now :) Once we get this merged, I'll update the implementations table. There are more implementations already :)

olizilla · 2017-06-21T15:41:17Z

@diasdavid excellent... I'm improving the build process at the moment, so package.json changes will be in there. I've got a nice site build & minify process in npm scripts right now, but I'm pulling it out into a makefile which will be equally nice.

I'll still be using thepackage.json to install the command line tools ensure needed in build are installed locally at known versions specific to the project rather than relying on whatever the user happens to have installed globally.

On the contributors implementation, it'd help me a lot if we could have a call about it. The spec'd change was to have it pull the data in at build time rather than in the browser, but then I couldn't resist simplifying the code once I was in there, but I recognise that I've gone off spec, so it'd be great to sync our expectations on what it should do. Some of it may ideas for the next sprint. In general though, I agree that it's too heavy for mobile clients on roaming data.

I'll fix that busted image now! Pesky OSX and it's case-insensitive file system.

Tiny request: Can we have the implementations.json be one .json per table? It gets exhausting to have to scroll so much.

Yes, but that'll require a change to the rendering logic too so I'd suggest this is more like a good idea for the next sprint.

Let's have anything related with the structure of the website, be inside the layouts folder. By that I mean the js and less into layouts
What's is the difference between the js inside js and the js inside static/js? Looks like there is no transpilation/bundling step, everything can just live in the static/js folder.

Good to chat about this one. Now there is a build step where we browserify the js into per page bundles and extract out all the common code into a common.js file that's loaded on each page, so the idea is that the js folder at the root is the "source js" and the build process will output the production files into the static/js. Same for the less files... I don't have super strong feelings about where the source files live, but it seems wise to keep them separate from the generated files, and somewhere other than the static dir as that triggers hugo magic and implies that they can be served up to the client.

Makefile build and deploy process

olizilla · 2017-06-21T22:19:25Z

@diasdavid PR updated with fixes and a SUPER SHINY MAKEFILE ...based build and deploy process. The deploy is basically cribbed from other makefiles around the protocol universe, while the build step is a port of the npm run script version, and I think it's pretty rad. Take a look.

Of note, I haven't tested the publish-to-domain target, as I didn't want to actually publish to the domain!

Fix publish-to-domain to use dnslink script

- Decrease minimum time between hexagons - Trigger contributor loading when the user is within 500px

daviddias · 2017-06-22T14:43:04Z

Makefile

-		--domain=$(DNSZONE) --record=$(DNSRECORD) --path=/ipfs/$(shell cat versions/current)
+publish-to-domain: auth.token versions/current
+	DNSIMPLE_TOKEN=$(shell cat auth.token) \
+	./dnslink.sh $(DOMAIN) $(shell cat versions/current)


@lgierth will like this :D

Actually let's move the token file to something like $HOME/.protocol/dnsimple.token -- just so it's never underneath the repo directory and there's no chance of ever accidentally committing it.

You can just assume that people put it there out-of-band (dnslink.sh will fail on its own).

@lgierth will move this as a separate issue and for a future sprint since last sprint ran out of time.

olizilla · 2017-06-22T14:43:11Z

✨ 🎷 🐩

olizilla added 2 commits June 12, 2017 15:47

Move html to content

30fa35d

- Pull head and footer to partials - Use hugo builtin GA template - Add package.json. Subsequent PR will clean up StandardJS warnings.

Fix head.html partial

93bb728

- Removes rogue index.css link from common head.html patial. - Fix line endings in README.md. - Simplify .gitignore to only contain file types this project might generate.

RichardLitt added the in progress label Jun 12, 2017

olizilla requested a review from daviddias June 12, 2017 15:07

Browserify the JS.

f539b31

- Use factor-bundle to create page specific bundles pull common deps into common.js

daviddias reviewed Jun 13, 2017

View reviewed changes

olizilla added 3 commits June 13, 2017 11:04

Pull src JS to top level. Fix html script links

5fc4750

Add generated js to .gitignore

4e59cc8

olizilla and others added 15 commits June 13, 2017 17:12

Pull the topbar into a partial

d962edf

Merge pull request #1 from tableflip/browserify

5d21980

Browserify

Merge pull request #3 from tableflip/topbar-partial

5f95647

Pull the topbar into a partial

Pulls implementation table into partial

56ff92f

WIP Builds impls html from data

48f5635

Impls page works as before, with content created at build time.

d83b79f

Fix homepage animation

df5ee56

Remove debug code

2e2e4c2

Merge pull request #4 from tableflip/data-driven-impls

963d50c

Data driven impls

Refactor bundles.json

fe26e56

Data driven bundles page

8f4bc30

- Port JS UI code to hugo partial bundle.html - Add coming soon section

Merge pull request #5 from tableflip/data-driven-bundles

1d07ffb

Data driven bundles

Fix line endings in .less files

f940f09

Remove generated css

305b59f

Fix less imports. Add build:css target

6af1ff4

olizilla and others added 3 commits June 20, 2017 17:13

WIP on build process

8e3bb00

Remove unused css, add onerror handler for missing images

3b9e9a0

Merge pull request #9 from tableflip/contributors

fdaa741

Pull in contributors data at build time

olizilla added 3 commits June 21, 2017 09:56

Add minify steps

992a86f

build step to create prod site

9d2aec9

Merge remote-tracking branch 'origin/move-content' into build-process

e653237

olizilla and others added 7 commits June 21, 2017 18:29

Fix peer-routing.svg casing

5fffc3b

Makefile based dev is GO!

8f097ec

Merge remote-tracking branch 'origin/move-content' into build-process

cbd9c1c

make dev-stop sounds better

7d1a31a

Pull README up to spec

1b116e0

Add versions dir

1c2a6de

Merge pull request #10 from tableflip/build-process

eec7cf9

Makefile build and deploy process

olizilla and others added 5 commits June 22, 2017 15:09

Fix publish-to-domain to use dnslink script

33daf62

Require DOMAIN as explicit arg

a35b96b

Merge pull request #11 from tableflip/dnslink

d9ca2a4

Fix publish-to-domain to use dnslink script

Speed up contributor image loading

68b36ad

- Decrease minimum time between hexagons - Trigger contributor loading when the user is within 500px

Decrease contributor loading delay to 50ms

d7a5894

daviddias reviewed Jun 22, 2017

View reviewed changes

daviddias mentioned this pull request Jun 24, 2017

Move token out of the repo #53

Closed

daviddias merged commit 60ab7cc into libp2p:master Jun 24, 2017

daviddias removed the in progress label Jun 24, 2017

daviddias mentioned this pull request Jun 24, 2017

Use partials in html pages #29

Closed

2 tasks

alanshaw deleted the move-content branch July 24, 2017 09:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Site refactor #52

Site refactor #52

olizilla commented Jun 12, 2017 •

edited

Loading

olizilla commented Jun 12, 2017

daviddias Jun 13, 2017

olizilla Jun 13, 2017

daviddias Jun 13, 2017

ghost Jun 15, 2017

daviddias Jun 13, 2017

olizilla Jun 13, 2017

daviddias commented Jun 13, 2017

olizilla commented Jun 13, 2017 •

edited

Loading

olizilla commented Jun 13, 2017

olizilla commented Jun 20, 2017

daviddias commented Jun 21, 2017 •

edited by olizilla

Loading

daviddias commented Jun 21, 2017

olizilla commented Jun 21, 2017

olizilla commented Jun 21, 2017

daviddias Jun 22, 2017

ghost Jun 22, 2017

daviddias Jun 24, 2017

olizilla commented Jun 22, 2017


		## Implementations & Bundles

		JSON arrays to update implementation & bundle status can be found in `/static/js/data`

Site refactor #52

Site refactor #52

Conversation

olizilla commented Jun 12, 2017 • edited Loading

olizilla commented Jun 12, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

daviddias commented Jun 13, 2017

olizilla commented Jun 13, 2017 • edited Loading

olizilla commented Jun 13, 2017

olizilla commented Jun 20, 2017

daviddias commented Jun 21, 2017 • edited by olizilla Loading

daviddias commented Jun 21, 2017

olizilla commented Jun 21, 2017

olizilla commented Jun 21, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

olizilla commented Jun 22, 2017

olizilla commented Jun 12, 2017 •

edited

Loading

olizilla commented Jun 13, 2017 •

edited

Loading

daviddias commented Jun 21, 2017 •

edited by olizilla

Loading