Pull in contributors data at build time #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
olizilla
commented
Jun 20, 2017
olizilla
commented
- Use hugo's getJSON function to grab contributors data at build time.
- Simplify contributors impl
- Simplify contributors impl
|
👓 |
alanshaw
requested changes
Jun 20, 2017
layouts/partials/contributors.html
Outdated
| z-index: 10; | ||
| } | ||
| #contributors .hex.show:hover + .hex { | ||
| } |
| link.style.background = '#333 url(' + item.photo + ') no-repeat center' | ||
| link.style.backgroundSize = 'cover' | ||
| cb(null, link) | ||
| } |
There was a problem hiding this comment.
If the image fails to load you halt the animation I think. You need an onerror handler to call the callback in this case.
layouts/partials/contributors.html
Outdated
| }, delay) | ||
| }) | ||
| } | ||
| renderWithPause(0, Date.now()) |
There was a problem hiding this comment.
Feels like you could extract this control flow logic from the rendering and publish as a module ;)
|
Fixed up! |
alanshaw
reviewed
Jun 21, 2017
layouts/partials/contributors.html
Outdated
| renderContributor(data[itemIndex], function (err, el) { | ||
| var nextIndex = itemIndex + 1 | ||
| if (err) renderWithPause(nextIndex) |
There was a problem hiding this comment.
Should this return renderWIthPause(/* ... */) here?
alanshaw
reviewed
Jun 21, 2017
layouts/partials/contributors.html
Outdated
| setTimeout(function () { | ||
| renderWithPause(itemIndex + 1, now) | ||
| renderWithPause(itemIndex + 1) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.