Implement ProtocolsHandler methods in wrappers. #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR forwards calls to some ProtocolsHandler methods that were previously not implemented in wrappers such as `MapInEvent`. It is unclear though how this can be implemented in some handlers such as `MultiHandler` as the information at hand does not enable it to decide which handler to forward the call to.
romanb
approved these changes
Aug 18, 2020
|
@twittner would you mind adding an entry to the swarm `CHANGELOG.md? |
|
@mxinden I already did so. |
|
Oh, that was fast, sorry, missed the commit. Thanks @romanb. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR forwards calls to some
ProtocolsHandlermethods that were previously not implemented in wrappers such asMapInEvent.It is unclear though how this can be implemented in some handlers such asMultiHandleras the information at hand does not enable it to decide which handler to forward the call to.NB that there is no guarantee at all that a
listen_protocolcall will eventually be followed by a call to eitherinject_fully_negotiated_inboundorinject_listener_upgrade_err.For context see #1707.