Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProtocolsHandler methods need to be implemented in helpers. #1707

Closed
twittner opened this issue Aug 17, 2020 · 1 comment
Closed

ProtocolsHandler methods need to be implemented in helpers. #1707

twittner opened this issue Aug 17, 2020 · 1 comment
Labels

Comments

@twittner
Copy link
Contributor

The ProtocolsHandler trait has several methods with default implementations, in particular

  • inject_address_change
  • inject_listen_upgrade_error

It also has some helper functionality like map_in, map_out or select. The traits impls from those do not implement these methods by forwarding the calls to their inner impls. ProtocolsHandler types which have been mapped or selected, will thus miss those callback.

@romanb
Copy link
Contributor

romanb commented Aug 18, 2020

Closed by #1707, though there may be more refinements later.

@romanb romanb closed this as completed Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants