Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add the ability to specify key type #65

Closed
wants to merge 1 commit into from
Closed

feat: add the ability to specify key type #65

wants to merge 1 commit into from

Conversation

ETeissonniere
Copy link

Submitting a small patch to let users specify the key type to be generated.

@ETeissonniere
Copy link
Author

Ain't sure why one test is timing out...

@ETeissonniere ETeissonniere mentioned this pull request Aug 24, 2017
Closed
daviddias
daviddias suggested changes Aug 25, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests need to be added and the README should describe which types of keys are possible

@ETeissonniere
Copy link
Author

@diasdavid indeed!

@daviddias daviddias added status/ready Ready to be worked status/deferred Conscious decision to pause or backlog and removed status/ready Ready to be worked labels Feb 5, 2018
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Oct 31, 2018
@jacobheun
Copy link
Contributor

This is supported now

@jacobheun jacobheun closed this Apr 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias requested changes

Assignees
No one assigned
Labels
status/ready Ready to be worked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ETeissonniere @jacobheun @daviddias