Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[WIP] feat: adding ability to specify a key type to use #955

Closed
wants to merge 2 commits into from
Closed

[WIP] feat: adding ability to specify a key type to use #955

wants to merge 2 commits into from

Conversation

ETeissonniere
Copy link

Depends on libp2p/js-peer-id#65

The following PR is enabling the possibility to specify the key type to use while running the jsipfs init command. Even if it isn't really useful at the moment, it open the path for a more modular implementation regarding key management.

@ETeissonniere ETeissonniere changed the title Adding specify ability to specify a key type to use Addingability to specify a key type to use Aug 24, 2017
@ETeissonniere ETeissonniere changed the title Addingability to specify a key type to use Adding ability to specify a key type to use Aug 24, 2017
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @developpsoft. Thank you for going ahead and taking a stab at this.

I'm concerned that merging something like this PR would create confusion amongst our users as it would present an option that is not implemented fully nor documented anywhere else with a roadmap to actually get it done.

I would be very happy to guide you if you want to lead the development of such feature, beware however that this requires touching pretty much the entire stack.

@ETeissonniere
Copy link
Author

Hi @diasdavid thanks for the follow up! Yeah indeed I agree with you, let's wait.

@ETeissonniere
Copy link
Author

Hi @diasdavid I finally have some spare time, so if you still want to lead me on this I am ready 😉

@daviddias
Copy link
Member

Awesome @developpsoft ! Let's start with something of smaller scope and I say this because this multikey support is something also still being figured out and merged in go-ipfs and I would rather make sure that all decisions have been made than having to guide you through flux.

Wanna pick some of the issues available here https://github.com/ipfs/js-ipfs/issues?q=is%3Aissue+is%3Aopen+label%3A%22help+wanted%22 to get started and familiar with the codebase?

@daviddias daviddias added status/ready Ready to be worked P3 Low: Not priority right now labels Oct 13, 2017
@daviddias daviddias changed the title Adding ability to specify a key type to use feat: adding ability to specify a key type to use May 29, 2018
@alanshaw alanshaw changed the title feat: adding ability to specify a key type to use [WIP] feat: adding ability to specify a key type to use Jan 22, 2019
@jacobheun
Copy link
Contributor

Fixed with #2553

@jacobheun jacobheun closed this Feb 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 Low: Not priority right now status/ready Ready to be worked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants