Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests are failing against master #191

Closed
dryajov opened this issue May 8, 2018 · 1 comment
Closed

Tests are failing against master #191

dryajov opened this issue May 8, 2018 · 1 comment

Comments

@dryajov
Copy link
Member

dryajov commented May 8, 2018

  • Version: master
  • Platform: All (at least it appears so)
  • Subsystem: libp2p, libp2p-secio

Type: Bug

Severity: Medium

Description:

Master is failing to build with:

screen shot 2018-05-08 at 1 02 42 pm

The Bad signature error message seems to be coming from libp2p-secio - https://github.com/libp2p/js-libp2p-secio/blob/6d09b472ec8d96040c54fbee630dc0b117a628bb/src/handshake/crypto.js#L151

I'm not sure about the second failure.

Steps to reproduce the error:

  • Clone this repo and run npm run test.
@dryajov dryajov mentioned this issue May 9, 2018
Closed
This was referenced May 12, 2018
Merged
Closed
@daviddias
Copy link
Member

fixed with #193

maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@dependabot @achingbrain
deps(dev): bump it-drain from 1.0.5 to 2.0.0 (libp2p#191)
e549691 
Bumps [it-drain](https://github.com/achingbrain/it) from 1.0.5 to 2.0.0.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/achingbrain/it/releases">it-drain's
releases</a>.</em></p>
<blockquote>
<h2>it-drain-v2.0.0</h2>
<h2><a
href="https://github.com/achingbrain/it/compare/it-drain-v1.0.5...it-drain-v2.0.0">it-drain-v2.0.0</a>
(2022-10-17)</h2>
<h3>⚠ BREAKING CHANGES</h3>
<ul>
<li>all modules are now published as ESM-only</li>
</ul>
<h3>Features</h3>
<ul>
<li>convert to typescript (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/28">#28</a>)
(<a
href="https://github.com/achingbrain/it/commit/f8a38bfb1b902e8101f1077eb33c3cea49819464">f8a38bf</a>)</li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/achingbrain/it/commit/c3a3077a90588be17452365e573e225c2c7db36f"><code>c3a3077</code></a>
chore(release): 2.0.0 [skip ci]</li>
<li><a
href="https://github.com/achingbrain/it/commit/c57270694011413abad0c6cac70181129f89b8e2"><code>c572706</code></a>
chore(release): 3.0.0 [skip ci]</li>
<li><a
href="https://github.com/achingbrain/it/commit/1415cdd019f32c08b1024e60bf3816619e361938"><code>1415cdd</code></a>
deps: update sibling dependencies</li>
<li><a
href="https://github.com/achingbrain/it/commit/417a1f3e7cb072a1b199bbe83af65a63ae797815"><code>417a1f3</code></a>
chore(release): 2.0.0 [skip ci]</li>
<li><a
href="https://github.com/achingbrain/it/commit/8bd4bd2d81c9aa26afc809a1478c20a15201a8b6"><code>8bd4bd2</code></a>
chore: update build scripts</li>
<li><a
href="https://github.com/achingbrain/it/commit/585df8dae93fb68a665bc64065366fb2c4add5d3"><code>585df8d</code></a>
docs: update readme</li>
<li><a
href="https://github.com/achingbrain/it/commit/f8a38bfb1b902e8101f1077eb33c3cea49819464"><code>f8a38bf</code></a>
feat!: convert to typescript (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/28">#28</a>)</li>
<li><a
href="https://github.com/achingbrain/it/commit/b621056a11c9bfe991d1040b22a46651fa907a3c"><code>b621056</code></a>
Publish</li>
<li><a
href="https://github.com/achingbrain/it/commit/da0c69f7ab16ddf6dd488cfed5844d1e6fa10366"><code>da0c69f</code></a>
fix: use EventTarget instead of EventEmitter (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/27">#27</a>)</li>
<li><a
href="https://github.com/achingbrain/it/commit/cfc852b428fb0c9ddf3bfbaad26c276b197779f0"><code>cfc852b</code></a>
fix: accepts iterable also (<a
href="https://github-redirect.dependabot.com/achingbrain/it/issues/24">#24</a>)</li>
<li>Additional commits viewable in <a
href="https://github.com/achingbrain/it/compare/[email protected]">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=it-drain&package-manager=npm_and_yarn&previous-version=1.0.5&new-version=2.0.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Alex Potsides <[email protected]>
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 5.0.1 [skip ci]
eb6e2cd 
## [5.0.1](libp2p/js-libp2p-websockets@v5.0.0...v5.0.1) (2022-12-08)

### Bug Fixes

* cannot catch EADDRINUSE ([libp2p#198](libp2p/js-libp2p-websockets#198)) ([c7312db](libp2p/js-libp2p-websockets@c7312db)), closes [libp2p#184](libp2p/js-libp2p-websockets#184)

### Dependencies

* **dev:** bump @libp2p/interface-mocks from 7.1.0 to 8.0.2 ([libp2p#199](libp2p/js-libp2p-websockets#199)) ([daff533](libp2p/js-libp2p-websockets@daff533)), closes [libp2p#318](https://github.com/libp2p/js-libp2p-websockets/issues/318) [libp2p#315](https://github.com/libp2p/js-libp2p-websockets/issues/315) [libp2p#313](https://github.com/libp2p/js-libp2p-websockets/issues/313) [libp2p#312](https://github.com/libp2p/js-libp2p-websockets/issues/312)
* **dev:** bump it-all from 1.0.6 to 2.0.0 ([libp2p#193](libp2p/js-libp2p-websockets#193)) ([6213f8f](libp2p/js-libp2p-websockets@6213f8f)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24)
* **dev:** bump it-drain from 1.0.5 to 2.0.0 ([libp2p#191](libp2p/js-libp2p-websockets#191)) ([e549691](libp2p/js-libp2p-websockets@e549691)), closes [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#28](libp2p/js-libp2p-websockets#28) [libp2p#27](libp2p/js-libp2p-websockets#27) [libp2p#24](libp2p/js-libp2p-websockets#24)
* **dev:** bump it-take from 1.0.2 to 2.0.0 ([libp2p#192](libp2p/js-libp2p-websockets#192)) ([4c037fc](libp2p/js-libp2p-websockets@4c037fc)), closes [libp2p#28](libp2p/js-libp2p-websockets#28)
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@eng-cc
fix: correction package.json exports types path (libp2p#191)
25e353b
maschad pushed a commit to maschad/js-libp2p that referenced this issue Jun 21, 2023
@semantic-release-bot
chore(release): 7.0.2 [skip ci]
d09bd34 
## [7.0.2](libp2p/js-libp2p-mdns@v7.0.1...v7.0.2) (2023-03-30)

### Bug Fixes

* correction package.json exports types path ([libp2p#191](libp2p/js-libp2p-mdns#191)) ([25e353b](libp2p/js-libp2p-mdns@25e353b))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dryajov @daviddias