-
Notifications
You must be signed in to change notification settings - Fork 46
Passing Strings instead of Buffers #28
Comments
Could you please try and write a failing test case for this? That would make it easier to fix :) |
@dignifiedquire absolutely, although a failing test case is hard because doing CI tests with go-ipfs is still not super smooth. However, this seems that is a simple error coming from pull-ws, that is converting 'everything' to strings (kind of expected since WebSockets run in the browser and there is no native Buffer impl there') Will double check |
I didn't mean a CI test with go, just a simple unit test that feeds in the same data, triggering this by itself |
I believe this is now fixed (bug was coming from go), please confirm @dignifiedquire |
@diasdavid I never saw this error, so that's your call :) |
I see. The way to test it is to make a dial from js-ipfs daemon to go-ipfs daemon while both using websockets (both have support for websockets on their master branches) |
Oh, of course I talked to @whyrusleeping to fix this..I just forgot about it. Yes this can be closed :) |
## [5.0.1](v5.0.0...v5.0.1) (2022-12-08) ### Bug Fixes * cannot catch EADDRINUSE ([#198](#198)) ([c7312db](c7312db)), closes [#184](#184) ### Dependencies * **dev:** bump @libp2p/interface-mocks from 7.1.0 to 8.0.2 ([#199](#199)) ([daff533](daff533)), closes [#318](https://github.com/libp2p/js-libp2p-websockets/issues/318) [#315](https://github.com/libp2p/js-libp2p-websockets/issues/315) [#313](https://github.com/libp2p/js-libp2p-websockets/issues/313) [#312](https://github.com/libp2p/js-libp2p-websockets/issues/312) * **dev:** bump it-all from 1.0.6 to 2.0.0 ([#193](#193)) ([6213f8f](6213f8f)), closes [#28](#28) [#28](#28) [#27](#27) [#24](#24) * **dev:** bump it-drain from 1.0.5 to 2.0.0 ([#191](#191)) ([e549691](e549691)), closes [#28](#28) [#28](#28) [#27](#27) [#24](#24) * **dev:** bump it-take from 1.0.2 to 2.0.0 ([#192](#192)) ([4c037fc](4c037fc)), closes [#28](#28)
Got this while testing WebSockets with go-ipfs
The text was updated successfully, but these errors were encountered: