This repository has been archived by the owner on Aug 29, 2023. It is now read-only.
feat: callbacks -> async / await #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: All places in the API that used callbacks are now replaced with async/await
* feat: support listen on array * chore: fix missing deps * chore: update interface version * docs: update readme for array listen * test: use port 0 * docs: add some more jsdocs * chore: fix travis support for ip6 on linux * refactor: clean up some code
This reverts commit 5009c2c.
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
The docs for this module are just terrible. License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Alan Shaw <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
License: MIT Signed-off-by: Jacob Heun <[email protected]>
jacobheun
approved these changes
Sep 16, 2019
License: MIT Signed-off-by: Jacob Heun <[email protected]>
achingbrain
reviewed
Sep 19, 2019
| * @param {Upgrader} options.upgrader | ||
| */ | ||
| constructor ({ upgrader }) { | ||
| assert(upgrader, 'An upgrader must be provided. See https://github.com/libp2p/interface-transport#upgrader.') |
There was a problem hiding this comment.
The readme example has this class instantiable without any options.
There was a problem hiding this comment.
Doing a PR shortly for another thing, I will include that there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #102
TODO: