This repository has been archived by the owner on Mar 11, 2020. It is now read-only.
fix(test): close with timeout #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: clean up git ignore and add docs to list
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The close with timeout test wasn't giving time for the listener to finish its upgrade, so the close test wasn't always in a consistent state before performing the close on the listener. This avoids that by waiting for the stack to finish before closing. The test was also simplified a bit.
Also cleaned up .gitignore so that ./docs aren't tracked (generated on release), and moved pre-commit to pre-push because pre-commit is annoying :).