Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rcmgr: fix JSON marshalling of ResourceManagerStat peer map #2156

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

MarcoPolo
Copy link
Collaborator

Fixes #2155

We need a better solution here. Some alternative solutions are here: libp2p/go-libp2p-resource-manager#67 (comment).

I think we should get a quick fix in here to unblock Kubo folks, but would be good to solve this more generally.

@marten-seemann marten-seemann changed the base branch from master to release-v026 March 1, 2023 20:08
@marten-seemann marten-seemann changed the title Quick fix to json Marshal rcmgr.ResourceManagerStat peer map correctly rcmgr: fix to json marshalling of ResourceManagerStat peer map Mar 1, 2023
@marten-seemann marten-seemann changed the title rcmgr: fix to json marshalling of ResourceManagerStat peer map rcmgr: fix JSON marshalling of ResourceManagerStat peer map Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rcmgr: rcmgr.ResourceManagerStat does not properly marshall json peer ids in the Peers map
2 participants