Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retract v0.26.1, release v0.26.2 #2153

Merged
merged 1 commit into from
Mar 1, 2023
Merged

Conversation

marten-seemann
Copy link
Contributor

Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Idk how you handle your release branches but just so you know you will need to front port this onto master (so retract is permanent).

@Jorropo
Copy link
Contributor

Jorropo commented Mar 1, 2023

Also in case you missed, your examples reverted to 0.25.

@marten-seemann
Copy link
Contributor Author

Also in case you missed, your examples reverted to 0.25.

That's fine, the release branch doesn't contain #2134.

@vyzo
Copy link
Contributor

vyzo commented Mar 1, 2023 via email

@marten-seemann
Copy link
Contributor Author

@vyzo see protocol/.github#481

@vyzo
Copy link
Contributor

vyzo commented Mar 1, 2023

oh, ouch.

@p-shahi
Copy link
Member

p-shahi commented Mar 1, 2023

blocked on #2156 (for kubo 0.19)

@MarcoPolo
Copy link
Collaborator

Should we get #2156 in as well before this release?

@p-shahi
Copy link
Member

p-shahi commented Mar 1, 2023

@MarcoPolo @Jorropo has indicated yes. I'll made this aware to kubo maintainers here: ipfs/kubo#9502 (comment)

@marten-seemann
Copy link
Contributor Author

Rebased to include #2156.

@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Suggested version: v0.26.2

Comparing to: v0.26.0 (diff)

Changes in go.mod file(s):

diff --git a/go.mod b/go.mod
index ac5631de..f9f77a52 100644
--- a/go.mod
+++ b/go.mod
@@ -44,7 +44,7 @@ require (
 	github.com/pbnjay/memory v0.0.0-20210728143218-7b4eea64cf58
 	github.com/prometheus/client_golang v1.14.0
 	github.com/quic-go/quic-go v0.33.0
-	github.com/quic-go/webtransport-go v0.5.1
+	github.com/quic-go/webtransport-go v0.5.2
 	github.com/raulk/go-watchdog v1.3.0
 	github.com/stretchr/testify v1.8.1
 	go.uber.org/fx v1.18.2diff --git a/test-plans/go.mod b/test-plans/go.mod
index 5c044526..dc2f0dd5 100644
--- a/test-plans/go.mod
+++ b/test-plans/go.mod
@@ -76,7 +76,7 @@ require (
 	github.com/quic-go/qtls-go1-19 v0.2.1 // indirect
 	github.com/quic-go/qtls-go1-20 v0.1.1 // indirect
 	github.com/quic-go/quic-go v0.33.0 // indirect
-	github.com/quic-go/webtransport-go v0.5.1 // indirect
+	github.com/quic-go/webtransport-go v0.5.2 // indirect
 	github.com/raulk/go-watchdog v1.3.0 // indirect
 	github.com/spaolacci/murmur3 v1.1.0 // indirect
 	go.uber.org/atomic v1.10.0 // indirect

gorelease says:

# github.com/libp2p/go-libp2p/p2p/host/autonat
## incompatible changes
(*AmbientAutoNAT).PublicAddr: removed
(*StaticAutoNAT).PublicAddr: removed
AutoNAT.PublicAddr: removed
Client.DialBack: changed from func(context.Context, github.com/libp2p/go-libp2p/core/peer.ID) (github.com/multiformats/go-multiaddr.Multiaddr, error) to func(context.Context, github.com/libp2p/go-libp2p/core/peer.ID) error

# github.com/libp2p/go-libp2p/p2p/host/basic
## compatible changes
HostOpts.EventBus: added

# github.com/libp2p/go-libp2p/p2p/net/swarm
## incompatible changes
NewSwarm: changed from func(github.com/libp2p/go-libp2p/core/peer.ID, github.com/libp2p/go-libp2p/core/peerstore.Peerstore, ...Option) (*Swarm, error) to func(github.com/libp2p/go-libp2p/core/peer.ID, github.com/libp2p/go-libp2p/core/peerstore.Peerstore, github.com/libp2p/go-libp2p/core/event.Bus, ...Option) (*Swarm, error)

# github.com/libp2p/go-libp2p/p2p/net/swarm/testing
## compatible changes
EventBus: added

# diagnostics
go.mod: the following requirements are needed
	github.com/libp2p/[email protected]
	github.com/cheekybits/[email protected]
	github.com/gorilla/[email protected]
	github.com/hashicorp/[email protected]
	github.com/libp2p/[email protected]
	github.com/libp2p/go-yamux/[email protected]
	github.com/lucas-clemente/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/marten-seemann/[email protected]
	github.com/mattn/[email protected]
	github.com/nxadm/[email protected]
	github.com/spacemonkeygo/[email protected]
	[email protected]
	gopkg.in/[email protected]
Run 'go mod tidy' to add missing requirements.
required module github.com/microcosm-cc/[email protected] retracted by module author: Retract older versions as only latest is to be depended upon

# summary
Cannot suggest a release version.
Module indirectly depends on a higher version of itself (v0.26.1) than the base version (v0.26.0).

gocompat says:

Your branch is up to date with 'origin/release-v026'.

Cutting a Release (when not on master)

This PR is targeting release-v026, which is not the default branch.
If you wish to cut a release once this PR is merged, please add the release label to this PR.

Cutting a Release (and modifying non-markdown files)

This PR is modifying both version.json and non-markdown files.
The Release Checker is not able to analyse files that are not checked in to release-v026. This might cause the above analysis to be inaccurate.
Please consider performing all the code changes in a separate PR before cutting the release.

Automatically created GitHub Release

A draft GitHub Release has been created.
It is going to be published when this PR is merged.
You can modify its' body to include any release notes you wish to include with the release.

@marten-seemann marten-seemann merged commit 59a14cf into release-v026 Mar 1, 2023
@galargh galargh added the release label Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants