move go-eventbus here #1681
Merged
move go-eventbus here #1681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Jakub Sztandera <[email protected]>
generify options.
Enable buffering by default
We only need TypeOf.
nit: avoid ValueOf
Fix close deadlock and Sub type error
1. It doesn't return an error and we weren't checking it anyways. 2. Avoid a goroutine unless we need it.
Issue: We could partially drain and end up with, e.g., a close event missing a matching open event.
fix: completely drain on close
Ensure that all subscribers see events in the same order. This also ensures that the subscribers never see the initial "latest" event after some other event. fixes #16
fix: serialize publishing
nit: fix with-node
Co-Authored-By: Łukasz Magiera <[email protected]>
[DEPENDENT MERGE] Return error rather than panic in Emit
) Co-authored-by: Raúl Kripalani <[email protected]>
Correct a typo
marten-seemann
force-pushed
the
merge-eventbus
branch
from
3db9ba5
to
19a8d57
Compare
Stebalien
approved these changes
Aug 17, 2022
marten-seemann
force-pushed
the
merge-eventbus
branch
from
19a8d57
to
4a897c3
Compare
marten-seemann
force-pushed
the
merge-eventbus
branch
from
4a897c3
to
40727b1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should merge libp2p/go-eventbus#48 first, there's a flaky test.
Part of #1556.