Leave overflow logic to go-msgio #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
go-msgio implements the message length limit (currently 8MB), so the secio reader can get away without re-implementing this logic. Instead, the reader lets go-msgio allocate a buffer when the output buffer is too small to hold the incoming message. This buffer is kept and drained into the output buffer(s) of Read() calls and released back to the msgio instance once it is fully drained. License: MIT Signed-off-by: Randall Leeds <[email protected]>
|
cool, LGTM. thanks! |
whyrusleeping
added a commit
that referenced
this pull request
Jan 30, 2016
Leave overflow logic to go-msgio
marten-seemann
added a commit
that referenced
this pull request
Apr 27, 2022
avoid using interface{} when generating certificates
marten-seemann
pushed a commit
that referenced
this pull request
Aug 17, 2022
Enable buffering by default
marten-seemann
added a commit
that referenced
this pull request
Sep 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
go-msgio implements the message length limit (currently 8MB), so the
secio reader can get away without re-implementing this logic.
Instead, the reader lets go-msgio allocate a buffer when the output
buffer is too small to hold the incoming message. This buffer is kept
and drained into the output buffer(s) of Read() calls and released back
to the msgio instance once it is fully drained.
License: MIT
Signed-off-by: Randall Leeds [email protected]