Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add semantic PR check to js-libp2p repos #93

Merged
merged 29 commits into from
Feb 22, 2023

Conversation

mpetrunic
Copy link
Member

Summary

Resolves #81

Why do you need this?

What else do we need to know?

DRI: myself

Reviewer's Checklist

  • It is clear where the request is coming from (if unsure, ask)
  • All the automated checks passed
  • The YAML changes reflect the summary of the request
  • The Terraform plan posted as a comment reflects the summary of the request

@mpetrunic mpetrunic requested a review from a team as a code owner November 29, 2022 09:38
@mpetrunic
Copy link
Member Author

cc @achingbrain @wemeetagain

@github-actions
Copy link
Contributor

github-actions bot commented Nov 29, 2022

Before merge, verify that all the following plans are correct. They will be applied as-is after the merge.

Terraform plans

libp2p

No changes. Your infrastructure matches the configuration.

Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.

Copy link
Contributor

@galargh galargh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating the PR 😄 Once we move the file, it'll be good to go from the GitHub Management point of view. I'll let others review before the merge though.

@mpetrunic mpetrunic requested review from achingbrain and galargh and removed request for wemeetagain, achingbrain and galargh November 29, 2022 10:40
@achingbrain
Copy link
Member

achingbrain commented Nov 29, 2022

I've not used this plugin before, does it pull the list of allowed scopes from the project config or does it need configuring in the action yaml?

@mpetrunic
Copy link
Member Author

I've not used this plugin before, does it pull the list of allowed scopes from the project config or does it need configuring in the action yaml?

https://github.com/libp2p/github-mgmt/pull/93/files#diff-e23c8debbc471dd71fbc4c6a03ce8197bc673f0470a994c63be03769c5096917R20

@libp2p-mgmt-read-write libp2p-mgmt-read-write bot requested a review from a team as a code owner December 11, 2022 01:08
@p-shahi
Copy link
Member

p-shahi commented Feb 15, 2023

@mpetrunic is all that's remaining for this a review? @thomaseizinger added pretty much the same thing in rust-libp2p so I think that's proof that this works. I approved but feel free to wait for @achingbrain

We'd want to enable this in go-libp2p too per: libp2p/go-libp2p#1931 cc @MarcoPolo

@mpetrunic
Copy link
Member Author

@mpetrunic is all that's remaining for this a review? @thomaseizinger added pretty much the same thing in rust-libp2p so I think that's proof that this works. I approved but feel free to wait for @achingbrain

We'd want to enable this in go-libp2p too per: libp2p/go-libp2p#1931 cc @MarcoPolo

Yup, think we are all waiting for approves here^^

@thomaseizinger
Copy link
Contributor

It works quite well for us!

Something I've also added is a lint for the length of the PR title to not exceed 72 chars. This might be interesting to include here as well.

Copy link
Contributor

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @mxinden We should probably switch to this being managed through here as well, assuming we can agree on the set of scopes :)

Comment on lines +21 to +26
feat
fix
chore
docs
deps
test
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also allow refactor and ci. Something to consider :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added those two here.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@p-shahi p-shahi requested a review from galargh February 21, 2023 19:19
@p-shahi
Copy link
Member

p-shahi commented Feb 21, 2023

I'll let others review before the merge though.

@galargh I think you've already reviewed but I don't want to merge this without your approval. PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[General] Add ci check to ensure PR titles follows semantic release rules
6 participants