Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[General] Add ci check to ensure PR titles follows semantic release rules #81

Closed
mpetrunic opened this issue Nov 22, 2022 · 2 comments · Fixed by #93
Closed

[General] Add ci check to ensure PR titles follows semantic release rules #81

mpetrunic opened this issue Nov 22, 2022 · 2 comments · Fixed by #93

Comments

@mpetrunic
Copy link
Member

Summary

Add github workflow to every js-libp2p* repo to check if PR title follows semantic release rules.
This action works great for us at chainsafe: https://github.com/amannn/action-semantic-pull-request

Why do you need this?

To prevent accidentally merging community PR with invalid title which doesn't show in changelog.

What else do we need to know?

DRI: myself

@galargh
Copy link
Contributor

galargh commented Nov 25, 2022

To accomplish this you could:

  1. Create the action-semantic-pull-request file in https://github.com/libp2p/github-mgmt/tree/master/files/.github/workflows
  2. Add a call which adds the workflow to all js repos to https://github.com/libp2p/github-mgmt/blob/master/scripts/src/actions/fix-yaml-config.ts. It'd have too look something like:
addFileToAllRepos(
  '.github/workflows/action-semantic-pull-request.yml',
  '.github/workflows/action-semantic-pull-request.yml',
  (repository: Repository) => repository.name.startsWith('js-libp2p-')
)

@galargh galargh moved this from 🤔 Triage to 🧐 In Review in InterPlanetary Developer Experience Nov 25, 2022
@mxinden
Copy link
Member

mxinden commented Dec 1, 2022

//CC @thomaseizinger given your work on libp2p/rust-libp2p#3054.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants