Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge test branch into production M2 #429

Open
wants to merge 27 commits into
base: production/M2
Choose a base branch
from

Conversation

IshDeshpa
Copy link
Contributor

Quality Assurance Checklist

To make reviews more efficient, please make sure the software feature meets the following standards and check everything off that meets the quality check. Once everything has been checked, the assigned reviewers will begin the review process. Edit this description to check off the list.

There are exceptions with all guidelines. As long as your decisions are justified, then you are good! Contact the reviewers or the leads about any exceptions.

Requirements

  • Followed Coding Style Guide
  • Presented/discussed in some capacity with others on the Controls team
  • Code Build checks pass
  • No merge conflicts
  • Software feature has documentation for it updated in both ReadTheDocs and the comments
  • Software feature has documentation for it updated
  • Testing
    • Software feature has test associated with it
    • Test provides useful information and uses relevant data to accurately represent Controls
    • Tested on hardware
    • NOTE: If test file already exists, use that one
  • If applicable, have you added the new feature to main.c?
  • Tagged appropriate issue ticket on this PR
  • Did you have fun?

Things to Consider

  • Even if the above are checked, is this the best way of writing my code?
    • It's possible to write code that works, but are there ways to make code more efficient?

MichaelMohn and others added 27 commits March 16, 2024 15:12
…it works. Added OSInit() so that the test runs; next step is to work through commented-out code and rename test file as Renode-only.
… Removed call to put control mode on CAN when testing (based on SENDTRITIUM_EXPOSE_VARS), updated brake pedal test value to be greater than new brake pedal percent threshold, added UpdateDisplay task since the fifo was filling up.
… have been the FSM logic which was fixed in the gear/display issue ticket.
…ince in a full hardware test, we would probably want to manipulate the inputs ourselves. We would also need to spin up other tasks if we wanted to run the motor.
…All app tests compile, but whether or not or are useful is another story.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants