Next.js SSR Regression when using 5.0.0 instead of 4.3.0

[Vadorequest]

I'm in the process of updating my OSS repository dependencies for https://github.com/UnlyEd/next-right-now, see PR UnlyEd/next-right-now#27.

I've noticed upgrading to [email protected], breaks SSR support.

Summary

• https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-hajt5ir65.now.sh/ works fine (commit)
• https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-bj7yrw148.now.sh/ doesn't work (commit) - REGRESSION DUE TO [email protected]
  - Restoring to this commit locally proves that, previous commit works fine with SSR, but doesn't when [email protected] is being used.

Full detail in the PR description.

I'm likely gonna rewrite the branch history to remove [email protected] (use 4.3.0) and see how it goes from there. I've thoroughly tested deployments one by one, with small subset of dependencies updates and I'm 100% positive [email protected] breaks it, I've reproduced this behaviour locally.

[chemicalkosek]

In 5.0.0, in order to have SSR you need to pass getDataFromTree (and install @apollo/react-ssr). From docs:

// import { getDataFromTree } from '@apollo/react-ssr';
// You can also override the configs for withApollo here, so if you want
// this page to have SSR (and to be a lambda) for SEO purposes and remove
// the loading state, uncomment the import at the beginning and this:
//
// export default withApollo(Index, { getDataFromTree });

[Vadorequest]

Thank you, I'll investigate.

Note that this behaviour will also be affected by updating to [email protected], because it installs @apollo/react-ssr in yarn.lock file. See https://github.com/apollographql/react-apollo/compare/[email protected]@3.1.4

I reproduced the regression locally upgrading either libraries, but on the online demo it's only affected when upgrading next-with-apollo, not when upgrading react-apollo, for some unknown reason...

Anyway, I'll follow your advice and migrate to 5.0.0 and see how it goes.

[Vadorequest]

@chemicalkosek Thank you very much for your help, I managed to fix this issue. See UnlyEd/next-right-now@5f3ad97

[Vadorequest]

I suggest to reference this issue for other people who'd migrate from v4 to v5 though.