v1-ssr-mst-aptd-gcms-lcz-sty update deps #27

Vadorequest · 2020-04-03T00:24:19Z

Goal

Updating all deps that can safely be updated.

Regressions

SSR doesn't work anymore (disable JS in browser and refresh page)
- https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1.now.sh/ works fine (master branch)
- https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-qp501x5kq.now.sh/ works fine (commit)
- https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-c2yjpkeje.now.sh/ works fine (commit)
- https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-nfs7u164x.now.sh/ works fine (commit)
- https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-hajt5ir65.now.sh/ works fine (commit)
- https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-bj7yrw148.now.sh/ doesn't work (commit) - REGRESSION DUE TO [email protected]
  - Restoring to this commit locally proves that, previous commit works fine with SSR, but doesn't when [email protected] is being used.

Fixed through #27 (comment)

Warnings

New warnings from React: "Cannot update a component while rendering another component"

Fixed by [email protected]

See https://fb.me/setstate-in-render

~~Issue seems to come from react-i18next useTranslation hook~~ (wrong assumption)

~~Or i18next when emiting something~~ (wrong assumption)

Hard to tell. It's just a warning with no incidence. It just highlights an existing issue that weren't obvious before. => Was due to react-apollo

Dependencies not updated

typescript: If updating to 3.8.3 then it breaks the build step on Zeit due to unknown . after ? in this.readonlyCookies?.[USER_LS_KEY]; - Zeit support has been contacted, no ETA fix, won't wait for a fix.

…[email protected] packages (devDeps, non critical)

…[email protected], [email protected] packages (react packages)

…[email protected], [email protected] packages (jest packages + non-critical)

Vadorequest · 2020-04-03T00:25:44Z

[GitHub Actions]
Deployment FAILED
Commit d41b493 failed to deploy to (click to see logs)

Vadorequest · 2020-04-03T00:28:13Z

[GitHub Actions]
Deployment FAILED
Commit d41b493 failed to deploy to (click to see logs)

…-eslint/[email protected], [email protected], [email protected], [email protected] (eslint packages)

Vadorequest · 2020-04-03T00:33:25Z

[GitHub Actions]
Deployment FAILED
Commit aefe1af failed to deploy to (click to see logs)

…ected token '.')

Vadorequest · 2020-04-03T00:38:45Z

[GitHub Actions]
Deployment FAILED
Commit 7ae81fe failed to deploy to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-mpbccddni.now.sh (click to see logs)

… definitions)

Vadorequest · 2020-04-03T01:27:42Z

[GitHub Actions]
Deployment FAILED
Commit fe93e92 failed to deploy to (click to see logs)

…ypes/js-cookie

Vadorequest · 2020-04-03T01:47:57Z

[GitHub Actions]
Deployment FAILED
Commit 8e7c40e failed to deploy to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-c2yjpkeje.now.sh (click to see logs)

Vadorequest · 2020-04-03T01:59:13Z

[GitHub Actions]
Deployment FAILED
Commit 9d8e102 failed to deploy to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-nfs7u164x.now.sh (click to see logs)

…[email protected], [email protected] packages (i18n)

Vadorequest · 2020-04-03T02:03:56Z

[GitHub Actions]
Deployment FAILED
Commit 7fd91e4 failed to deploy to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-hajt5ir65.now.sh (click to see logs)

Vadorequest · 2020-04-03T02:14:03Z

[GitHub Actions]
Deployment SUCCESS
Commit b1d6ff7 successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-ez7brhoq3.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

Vadorequest · 2020-04-03T02:18:12Z

[GitHub Actions]
E2E tests SUCCESS

Vadorequest · 2020-04-03T02:40:08Z

[GitHub Actions]
Deployment SUCCESS
Commit 6f77b16 successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-axb1uwh7s.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

…r not

Vadorequest · 2020-04-03T13:54:58Z

[GitHub Actions]
Deployment SUCCESS
Commit 072ae7f successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-ios9tcm2b.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

Vadorequest · 2020-04-03T13:59:07Z

Rewrote history to rollback to [email protected] worked just fine. SSR support works again now.

Replaying all packages updates one by one (I believe next-with-apollo may not be the only one breaking SSR)

Vadorequest · 2020-04-03T13:59:35Z

[GitHub Actions]
Deployment SUCCESS
Commit 6655f04 successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-j58fc7w11.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

Vadorequest · 2020-04-03T14:03:46Z

[GitHub Actions]
E2E tests SUCCESS

Vadorequest · 2020-04-03T14:07:01Z

[GitHub Actions]
Deployment SUCCESS
Commit e745ceb successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-9ahzq3trj.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

Vadorequest · 2020-04-03T14:11:14Z

[GitHub Actions]
E2E tests SUCCESS

…it installs @apollo/react-ssr which requires to change the current configuration - See lfades/next-with-apollo#126 (comment))

Vadorequest · 2020-04-03T14:15:50Z

[GitHub Actions]
Deployment SUCCESS
Commit a961591 successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-5mjqkqpo0.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

Vadorequest · 2020-04-03T14:20:01Z

[GitHub Actions]
E2E tests SUCCESS

…/react-ssr and update HOC for GraphQL data fetching - See lfades/next-with-apollo#126 (comment) (tested locally and it DOES fix the SSR issue!)

Vadorequest · 2020-04-03T14:31:42Z

[GitHub Actions]
Deployment SUCCESS
Commit 5f3ad97 successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-mosund99m.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

Vadorequest · 2020-04-03T14:34:02Z

Confirming SSR works fine now https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-mosund99m.now.sh/

Vadorequest · 2020-04-03T14:36:58Z

[GitHub Actions]
E2E tests SUCCESS

…tstrap NavLink is an actual link and not just a decorator)

… directly, or link won't work if JS is disabled)

Vadorequest · 2020-04-03T15:08:46Z

[GitHub Actions]
Deployment SUCCESS
Commit 9f79e6f successfully deployed to https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-6zm2ozcos.now.sh
Deployment aliased as https://nrn-v1-ssr-mst-aptd-gcms-lcz-sty-c1-v1-ssr-mst-aptd-gcms-lcz-sty-update-deps.now.sh

Vadorequest · 2020-04-03T15:12:35Z

[GitHub Actions]
E2E tests SUCCESS

Vadorequest added 7 commits April 3, 2020 01:53

[Package] Update now to 17.1.1

24439b7

[Package] Update @emotion/core to 10.0.28

5846469

[Package] Update 4x @FortAwesome packages

3e0a00b

[Package] Update @now/[email protected], @svgr/[email protected], [email protected], v…

1b079ab

…[email protected] packages (devDeps, non critical)

[Package] Update @sentry/[email protected], @sentry/[email protected] packages

1e1b719

[Package] Update @types/[email protected], [email protected], r…

d263134

…[email protected], [email protected] packages (react packages)

[Package] Update @types/[email protected], [email protected], [email protected], typ…

d41b493

…[email protected], [email protected] packages (jest packages + non-critical)

[Package] Update @typescript-eslint/[email protected], @typescript…

aefe1af

…-eslint/[email protected], [email protected], [email protected], [email protected] (eslint packages)

[Package] Revert typescript from 3.8.3 to 3.7.5 - (SyntaxError: Unexp…

7ae81fe

…ected token '.')

Vadorequest added 3 commits April 3, 2020 03:17

[Package] Update @types/[email protected] package

8f3f504

[Package] Update [email protected] package [MAJOR] (tested locally)

35ab312

[Package] Update [email protected], [email protected] packages (TS…

fe93e92

… definitions)

Vadorequest added 4 commits April 3, 2020 03:28

[Package] Revert cypress from 4.3.0 to 3.8.3 - (socket hang up)

810d13e

[Package] Revert @types/js-cookie from 2.2.5 to 2.2.4 - (socket hang up)

3c222cb

Change team to avoid pricing limit...

efb538f

[Package] Update [email protected] package [MAJOR] (tested locally) + @t…

8e7c40e

…ypes/js-cookie

[Package] Update [email protected] package [MAJOR] (tested locally)

9d8e102

[Package] Update [email protected], [email protected], i18nex…

7fd91e4

…[email protected], [email protected] packages (i18n)

Vadorequest mentioned this pull request Apr 3, 2020

Cannot update a component while rendering a different component i18next/react-i18next#1077

Closed

Vadorequest added 3 commits April 3, 2020 15:48

Restore OSS team id

ca30a5a

Misc doc

5eb3019

Specify for each ENV value if the mentioned value is actually valid o…

7c9c32e

…r not

Vadorequest force-pushed the v1-ssr-mst-aptd-gcms-lcz-sty-update-deps branch from 5f2c7bd to 7c9c32e Compare April 3, 2020 13:49

Vadorequest added 2 commits April 3, 2020 15:51

[Package] Update [email protected] package

072ae7f

[Package] Update [email protected] package (FRAMEWORK)

6655f04

[Package] Update [email protected] package (MAJOR)

e745ceb

[Package] Update [email protected] package (This BREAKS SSR because …

a961591

…it installs @apollo/react-ssr which requires to change the current configuration - See lfades/next-with-apollo#126 (comment))

Vadorequest mentioned this pull request Apr 3, 2020

Prevent new data re-render attempts during an existing render apollographql/react-apollo#3902

Merged

[Package] Update [email protected] package [MAJOR] + add @apollo…

5f3ad97

…/react-ssr and update HOC for GraphQL data fetching - See lfades/next-with-apollo#126 (comment) (tested locally and it DOES fix the SSR issue!)

Vadorequest mentioned this pull request Apr 3, 2020

Ability to disable javascript for the url under test cypress-io/cypress#1611

Open

Vadorequest added 2 commits April 3, 2020 17:01

Remove duplicates <a> elements in Nav component (had forgotten a reac…

75179a7

…tstrap NavLink is an actual link and not just a decorator)

Use Next.js <Link> element properly (must embed a <a> child, not text…

9f79e6f

… directly, or link won't work if JS is disabled)

Powered by header

ad456eb

Vadorequest merged commit 3eeaa45 into v1-ssr-mst-aptd-gcms-lcz-sty Apr 3, 2020

Vadorequest deleted the v1-ssr-mst-aptd-gcms-lcz-sty-update-deps branch April 3, 2020 15:48

Vadorequest changed the title ~~V1 ssr mst aptd gcms lcz sty update deps~~ v1-ssr-mst-aptd-gcms-lcz-sty update deps Apr 3, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v1-ssr-mst-aptd-gcms-lcz-sty update deps #27

v1-ssr-mst-aptd-gcms-lcz-sty update deps #27

Vadorequest commented Apr 3, 2020 •

edited

Loading

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

v1-ssr-mst-aptd-gcms-lcz-sty update deps #27

v1-ssr-mst-aptd-gcms-lcz-sty update deps #27

Conversation

Vadorequest commented Apr 3, 2020 • edited Loading

Goal

Regressions

Warnings

Dependencies not updated

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020

Vadorequest commented Apr 3, 2020 •

edited

Loading