normalize IE9 1223 response to 204 no content #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexich
reviewed
Dec 29, 2017
test/adapters_fetch_spec.js
Outdated
| @@ -3,6 +3,7 @@ | |||
| /* global describe, it */ | |||
| /* eslint import/no-extraneous-dependencies: ["error", {"devDependencies": true}] */ | |||
| import { expect } from "chai"; | |||
| import { fail, ok } from "assert"; | |||
There was a problem hiding this comment.
Pls, rewrite test using chai. I think we don't need this dependence
test/adapters_fetch_spec.js
Outdated
|
|
||
| return fetch(fetchApi)("url", "opts") | ||
| .then(()=> { | ||
| ok(true, "response status 1223 normalised"); |
test/adapters_fetch_spec.js
Outdated
| ok(true, "response status 1223 normalised"); | ||
| }) | ||
| .catch(()=> { | ||
| fail("response status 1223 not normalized"); |
|
@lexich I've addressed your comments |
|
Thx @dagda1 Good work 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to tackle #189 where IE9 sometimes returns status code 1223 instead of HTTP 204 No Content.
Usually when responding to a PUT request.
The PR changes fetch adapter to coerces HTTP 1223 into 204 No Content.