Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE9 returning 1223 for HTTP 204 no content #189

Open
dagda1 opened this issue Dec 28, 2017 · 1 comment
Open

IE9 returning 1223 for HTTP 204 no content #189

dagda1 opened this issue Dec 28, 2017 · 1 comment

Comments

@dagda1
Copy link

dagda1 commented Dec 28, 2017

I've just upgraded to 0.11.1 and noticed that our IE9 api requests that return 204 are now noticeably failing. This is because of this bug.

It turns out they were always failing but the old code was returning Promise.reject(data) instead of this update.

I was going to submit a PR to fix this but I want to first check that you would entertain a bug fix for IE9. It is sadly on our list of supported browsers and is not up for removal
@lexich
Copy link
Owner

lexich commented Dec 28, 2017

Hi @dagda1 I of course accept this PR. Welcome))

@dagda1 dagda1 mentioned this issue Dec 28, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dagda1 @lexich