Skip to content

Commit

Permalink
Squashed commit of the following:
Browse files Browse the repository at this point in the history
commit 5ef6613
Author: Matt Mitchell <[email protected]>
Date:   Wed Aug 24 09:22:40 2022 -0700

    Explicitly avoid signing python.cat (dotnet#192)

    Set the python.cat signature to None so that tooling doesn't complain about not having a signature mapping for this file.

commit 321399a
Author: Matt Mitchell <[email protected]>
Date:   Tue Aug 23 11:51:37 2022 -0700

    Do not attempt to sign .cat files (dotnet#190)

    .cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
  • Loading branch information
lewing committed Aug 24, 2022
1 parent 81cc0e4 commit 0b7f096
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion eng/Signing.props
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
<FileExtensionSignInfo Update="@(FileExtensionSignInfo)" CertificateName="3PartySHA2" />
<FileExtensionSignInfo Update=".nupkg" CertificateName="NuGet" />
<FileExtensionSignInfo Update=".zip" CertificateName="None" />
<FileExtensionSignInfo Include=".cat" CertificateName="3PartySHA2" />
<FileExtensionSignInfo Include=".msi" CertificateName="MicrosoftDotNet500" />
<FileExtensionSignInfo Include=".pyd" CertificateName="3PartySHA2" />

Expand All @@ -18,6 +17,9 @@
<FileExtensionSignInfo Update=".ps1" CertificateName="None" />
<FileExtensionSignInfo Update=".js" CertificateName="None" />
<FileExtensionSignInfo Include=".vbs" CertificateName="None" />

<!-- python.cat is already signed and cannot be re-signed -->
<FileSignInfo Include="python.cat" CertificateName="None" />
</ItemGroup>

<ItemGroup>
Expand Down

0 comments on commit 0b7f096

Please sign in to comment.