[release/7.0-rc1] Do not attempt to sign .cat files #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
mmitche
changed the title
lewing
approved these changes
Aug 23, 2022
hoyosjs
approved these changes
Aug 23, 2022
mmitche
added a commit
to mmitche/emsdk
that referenced
this pull request
Aug 23, 2022
.cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
mmitche
added a commit
to mmitche/emsdk
that referenced
this pull request
Aug 23, 2022
.cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
lewing
added a commit
to lewing/emsdk
that referenced
this pull request
Aug 24, 2022
commit 5ef6613 Author: Matt Mitchell <[email protected]> Date: Wed Aug 24 09:22:40 2022 -0700 Explicitly avoid signing python.cat (dotnet#192) Set the python.cat signature to None so that tooling doesn't complain about not having a signature mapping for this file. commit 321399a Author: Matt Mitchell <[email protected]> Date: Tue Aug 23 11:51:37 2022 -0700 Do not attempt to sign .cat files (dotnet#190) .cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
lewing
added a commit
that referenced
this pull request
Aug 24, 2022
commit 5ef6613 Author: Matt Mitchell <[email protected]> Date: Wed Aug 24 09:22:40 2022 -0700 Explicitly avoid signing python.cat (#192) Set the python.cat signature to None so that tooling doesn't complain about not having a signature mapping for this file. commit 321399a Author: Matt Mitchell <[email protected]> Date: Tue Aug 23 11:51:37 2022 -0700 Do not attempt to sign .cat files (#190) .cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.
lewing
added a commit
that referenced
this pull request
Sep 8, 2022
* Do not attempt to sign .cat files (#190) .cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds. * Update Signing.props Co-authored-by: Larry Ewing <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.cat files cannot be dual signed. However, there was a bug in signtool.exe where an attempt to add a second signature did not fail, and instead corrupted the cat file. Validation steps were added in the signing process to avoid this situation, and this broke builds.