Ability to opt of of using npm ci

[apaleslimghost]

Expected Behavior

Being able to tell lerna bootstrap to explicitly use npm install instead of npm ci

Current Behavior

Since 3.0.0-beta.15, lerna bootstrap uses npm ci if it's a version of npm that supports it and you pass the --ci flag. However, on CI environments the --ci flag is always true, and there's no way to turn it off without messing around with environment variables, which would have other side effects.

Context

Since we're not committing package-lock.json files (our current tooling doesn't play nicely with them at present) npm ci errors, and we can't currently use lerna on CI with [email protected].

[evocateur]

lerna bootstrap --no-ci doesn't work?

[apaleslimghost]

I tried it and it didn't seem to work 🤷‍♀️ Financial-Times/x-dash@8a18f7e

[evocateur]

Hrm, okay, that wasn’t intended. A CLI flag should always override file- or env-based configuration.

…

On Jun 5, 2018, at 03:09, matt brennan ***@***.***> wrote: I tried it and it didn't seem to work 🤷‍♀️ ***@***.*** — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[apaleslimghost]

did a bit of digging into yargs' parsing and it looks like .config() takes precedence over command line args

[evocateur]

Good catch!

…

On Jun 5, 2018, at 09:10, matt brennan ***@***.***> wrote: did a bit of digging into yargs' parsing and it looks like .config() takes precedence over command line args — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[track0x1]

What is the verdict on this? Can we lerna bootstrap --no-ci? Or better, can this functionality be changed to be explicit? There was nothing indicating that lerna would use npm ci when my build ran on AWS Codebuild. ☹️

[evocateur]

I plan on releasing the next version of lerna 3 sometime this week.

[raymondfeng]

@evocateur We cannot set the ci value in lerna.json even when --ci flag is not present on the CLI. Is it by design?

[evocateur]

Not intentional, no, but the result of a feature I personally haven't used in over a year. I'm not sure why you wouldn't want a faster install during a CI build.

You should still be able to pass --no-ci to disable it, which is relatively easy to encode into your CI scripts. Switching to relative file: specifiers that serialize the whole tree at the root would be better long-term than relying on lerna bootstrap.

[raymondfeng]

@evocateur We don't check in package-lock.json files and npm ci fails for our build.

--no-ci works for us. I was trying to do so in lerna.json as we configure other commands there. But the ci property is not honored.

[evocateur]

Yeah, that's an unfortunate side-effect from how the options are configured. I should probably move this block into the base command constructor, where the options are merged with the config file...

[evocateur]

@raymondfeng Next release should fix this for you properly.

[raymondfeng]

@evocateur Great! We appreciate your prompt response.

[lock]

This thread has been automatically locked because there has not been any recent activity after it was closed. Please open a new issue for related bugs.