ci: Initial CircleCI config #6
Conversation
| @@ -23,7 +23,7 @@ | |||
| "test": "echo \"Error: run tests from root\" && exit 1" | |||
| }, | |||
| "dependencies": { | |||
| "@aerogear/apollo-voyager-server": "1.0.0", | |||
| "@aerogear/apollo-voyager-server": "file:../apollo-voyager-server", | |||
There was a problem hiding this comment.
This will cause havoc on release time, however this could be swapped by lerna for release time. What is the context/problem for this change. Just for my information
There was a problem hiding this comment.
Seeing it recommended in many places. It basically reduces the dependency on using the lerna bootstrap command.
lerna/lerna#1449 (comment)
lerna/lerna#1462 (comment)
I am going to test the old way again and see can I get it working.
There was a problem hiding this comment.
@wtrocki managed to get the solution that doesn't require this.
| filters: | ||
| tags: | ||
| only: /.*/ | ||
| - npm_publish: |
There was a problem hiding this comment.
We can reuse scripts done js-sdk to support this case. Not sure if we want to copy this along with docs now or it will be separate ticket
There was a problem hiding this comment.
Separate ticket here: https://issues.jboss.org/browse/AEROGEAR-8181
.circleci/config.yml
Outdated
| - run: | ||
| name: compile | ||
| command: npm run compile | ||
| # - save_cache: |
There was a problem hiding this comment.
Does this has any value or are just experiments?
@wtrocki sorry for such a noisy PR. Baiscally, this gives us a working CI (without tests for now). I had to do some things to get this working.
package-lock.jsonanymore.package-lock.jsonfile:specifiers for sibling dependencies.graphqland@types/graphqlas dev dependencies at the top level. This stops us from needing to do any hoisting.Result: