Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Fix Hermes version displaying 0.70.6 on RN 0.71.1 #1449

Closed
leotm opened this issue Jan 31, 2023 · 0 comments · Fixed by #1451
Closed

[iOS] Fix Hermes version displaying 0.70.6 on RN 0.71.1 #1449

leotm opened this issue Jan 31, 2023 · 0 comments · Fixed by #1451
Labels
hermes JS engine for RN (optimised: TTI, size, RAM) inconsistent ios Native iOS changes (Swift, C++, CocoaPods) 🐞 Bugerino: Summin' ain't work'n jimmy react native react-native-community.github.io/upgrade-helper xcode Xcode: pbxproj, etc
Milestone
React Native 0.71

Comments

@leotm
Copy link
Owner

leotm commented Jan 31, 2023 •
edited
Loading

Since

Follow-up with

Quickfix

Screenshot 2023-01-31 at 09 06 33

Applying then reverting this, Hermes now perm showing 0.71.1

Tested npx react-native init RN0711 displaying Hermes 0.71.1
@leotm leotm added react native react-native-community.github.io/upgrade-helper ios Native iOS changes (Swift, C++, CocoaPods) labels Jan 31, 2023
@leotm leotm added this to the React Native 0.71 milestone Jan 31, 2023
@leotm leotm changed the title Fix Hermes version displaying 0.70.6 Fix Hermes version displaying 0.70.6 on iOS Jan 31, 2023
@leotm leotm changed the title Fix Hermes version displaying 0.70.6 on iOS [iOS] Fix Hermes version displaying 0.70.6 Jan 31, 2023
@leotm leotm mentioned this issue Jan 31, 2023
Closed
leotm added a commit that referenced this issue Jan 31, 2023
@leotm
Add plist MARKETING_VERSION to pbxproj
d122c52 
Fix: #1449

Fix: #1450

Missed during upg, ref:
- https://react-native-community.github.io/upgrade-helper/?from=0.70.6&to=0.71.0
@leotm leotm mentioned this issue Jan 31, 2023
Merged
@leotm leotm added the 🐞 Bugerino: Summin' ain't work'n jimmy label Jan 31, 2023
@leotm leotm changed the title [iOS] Fix Hermes version displaying 0.70.6 [iOS] Fix Hermes version displaying 0.70.6 on RN 0.71.1 Jan 31, 2023
@leotm leotm changed the title [iOS] Fix Hermes version displaying 0.70.6 on RN 0.71.1 [iOS] Fix Hermes version displaying 0.70.6 on RN 0.71.1 Jan 31, 2023
@leotm leotm added the hermes JS engine for RN (optimised: TTI, size, RAM) label Jan 31, 2023
leotm added a commit that referenced this issue Jan 31, 2023
@leotm
Add plist MARKETING_VERSION to pbxproj (#1451)
b5bfdc4 
Fix: #1449

Fix: #1450

Missed during upg, ref:
- https://react-native-community.github.io/upgrade-helper/?from=0.70.6&to=0.71.0
@leotm leotm added the xcode Xcode: pbxproj, etc label Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hermes JS engine for RN (optimised: TTI, size, RAM) inconsistent ios Native iOS changes (Swift, C++, CocoaPods) 🐞 Bugerino: Summin' ain't work'n jimmy react native react-native-community.github.io/upgrade-helper xcode Xcode: pbxproj, etc
Projects
None yet
Milestone
React Native 0.71
Development

Successfully merging a pull request may close this issue.

Add plist MARKETING_VERSION to pbxproj leotm/react-native-template-new-architecture
1 participant
@leotm