Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update info.plist #34919

Closed
wants to merge 3 commits into from
Closed

Update info.plist #34919

wants to merge 3 commits into from

Conversation

erfinbadrian
Copy link
Contributor

@erfinbadrian erfinbadrian commented Oct 10, 2022

Change version of rn apps following xcode settings.

Summary

Changelog

[iOS][Fixed] - Automatically following version on xcode.

Test Plan

Change version of rn apps following xcode settings.
@kelset
Copy link
Contributor

kelset commented Oct 10, 2022

can you give for context for why this change is needed? is that how Xcode14 generates new project? is there a changelog that explains why it's needed?

@erfinbadrian
Copy link
Contributor Author

erfinbadrian commented Oct 10, 2022

can you give for context for why this change is needed? is that how Xcode14 generates new project? is there a changelog that explains why it's needed?

You will have problem when you release it to appstore.
if you make it static with version 1 and not following change on xcode version.
you will get confuse because need to change version on info.plist.
with this change you just change version on xcode not need change on info.plist.

*as we know we need upload to appstore with higher version of apps. so if you do that we need to edit info.plist everytime we want upload to appstore. So with this changes will help changing version on xcode.

@cipolleschi
Copy link
Contributor

Could you update the changelog properly, please?
The format should be:

## Changelog
[iOS][Fixed] - Message

Thank you so much!

@erfinbadrian
Copy link
Contributor Author

Could you update the changelog properly, please? The format should be:

## Changelog
[iOS][Fixed] - Message

Thank you so much!

Edited sir.

Thank you!

@react-native-bot react-native-bot added Bug Platform: iOS iOS applications. labels Oct 10, 2022
@analysis-bot
Copy link

analysis-bot commented Oct 10, 2022

Platform Engine Arch Size (bytes) Diff
android hermes arm64-v8a 7,747,285 -25,133
android hermes armeabi-v7a 7,149,253 -24,356
android hermes x86 8,058,367 -27,330
android hermes x86_64 8,029,424 -27,859
android jsc arm64-v8a 9,608,518 -25,038
android jsc armeabi-v7a 8,373,768 -24,282
android jsc x86 9,555,784 -27,224
android jsc x86_64 10,148,324 -27,774

Base commit: 0e2f090
Branch: main

@facebook-github-bot
Copy link
Contributor

Hi @erfinbadrian!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@erfinbadrian erfinbadrian requested review from iBotPeaches and cipolleschi and removed request for iBotPeaches October 10, 2022 13:47
@analysis-bot
Copy link

analysis-bot commented Oct 10, 2022

Platform Engine Arch Size (bytes) Diff
ios - universal n/a --

Base commit: 0e2f090
Branch: main

@react-native-bot react-native-bot added the No CLA Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2022
@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2022
@react-native-bot react-native-bot removed the No CLA Authors need to sign the CLA before a PR can be reviewed. label Oct 11, 2022
@erfinbadrian erfinbadrian requested review from iBotPeaches and kelset and removed request for cipolleschi and iBotPeaches October 12, 2022 06:25
@facebook-github-bot
Copy link
Contributor

@motiz88 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@react-native-bot
Copy link
Collaborator

This pull request was successfully merged by @erfinbadrian in dcd2114.

When will my fix make it into a release? | Upcoming Releases

@react-native-bot react-native-bot added the Merged This PR has been merged. label Oct 13, 2022
@kelset
Copy link
Contributor

kelset commented Oct 13, 2022

@erfinbadrian how did you test this change?

I just tried to create a sample app from main (where your commit has landed) and it breaks with

The request to open "org.reactjs.native.example.RNTestProject" failed.
Underlying error (domain=FBSOpenApplicationErrorDomain, code=4):
	The operation couldn’t be completed. Application info provider (FBSApplicationLibrary) returned nil for "org.reactjs.native.example.RNTestProject"
	Application info provider (FBSApplicationLibrary) returned nil for "org.reactjs.native.example.RNTestProject"

You can get this result by being on main and running yarn test-e2e-local -t RNTestProject


we might have to revert this @cipolleschi

mohitcharkha pushed a commit to mohitcharkha/react-native that referenced this pull request Oct 17, 2022
Summary:
Change version of rn apps following xcode settings.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[iOS][Fixed] - Automatically following version on xcode.

Pull Request resolved: facebook#34919

Reviewed By: cipolleschi

Differential Revision: D40340271

Pulled By: motiz88

fbshipit-source-id: a2263a8c7a70847fe6fcedcd82c5109100aafde6
@kelset
Copy link
Contributor

kelset commented Oct 18, 2022

fixed here: #35012

facebook-github-bot pushed a commit that referenced this pull request Oct 18, 2022
Summary:
Recently this PR got merged #34919 that aligned the info.plist to the current default. Problem: the variable `MARKETING_VERSION` was not set in the template, so generating a new project and testing on iOS would fail accordingly:

<img width="1400" alt="Screenshot 2022-10-18 at 15 27 27" src="https://user-images.githubusercontent.com/16104054/196461640-470079f5-0f64-471f-8221-0d17f2b0114f.png">

This PR takes care of setting the variable so that the app can build successfully.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[iOS] [Fixed] - add MARKETING_VERSION to template project

Pull Request resolved: #35012

Test Plan: Run `yarn test-e2e-local -t RNTestProject`, apps builds correctly and runs on simulator.

Reviewed By: cipolleschi

Differential Revision: D40472420

Pulled By: cortinico

fbshipit-source-id: 18ddd57ce54186a101321583a7a8391e97ca9511
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
Summary:
Change version of rn apps following xcode settings.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->
[iOS][Fixed] - Automatically following version on xcode.

Pull Request resolved: facebook#34919

Reviewed By: cipolleschi

Differential Revision: D40340271

Pulled By: motiz88

fbshipit-source-id: a2263a8c7a70847fe6fcedcd82c5109100aafde6
OlimpiaZurek pushed a commit to OlimpiaZurek/react-native that referenced this pull request May 22, 2023
…ok#35012)

Summary:
Recently this PR got merged facebook#34919 that aligned the info.plist to the current default. Problem: the variable `MARKETING_VERSION` was not set in the template, so generating a new project and testing on iOS would fail accordingly:

<img width="1400" alt="Screenshot 2022-10-18 at 15 27 27" src="https://user-images.githubusercontent.com/16104054/196461640-470079f5-0f64-471f-8221-0d17f2b0114f.png">

This PR takes care of setting the variable so that the app can build successfully.

## Changelog

<!-- Help reviewers and the release process by writing your own changelog entry. For an example, see:
https://reactnative.dev/contributing/changelogs-in-pull-requests
-->

[iOS] [Fixed] - add MARKETING_VERSION to template project

Pull Request resolved: facebook#35012

Test Plan: Run `yarn test-e2e-local -t RNTestProject`, apps builds correctly and runs on simulator.

Reviewed By: cipolleschi

Differential Revision: D40472420

Pulled By: cortinico

fbshipit-source-id: 18ddd57ce54186a101321583a7a8391e97ca9511
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged This PR has been merged. Platform: iOS iOS applications.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants