Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing undeclared dependencies #23

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

bitboxx
Copy link
Contributor

@bitboxx bitboxx commented Jan 23, 2021

I'm adding dependencies that are being require'd in the codebase, but not defined in package.json. This issue is detected by Yarn 2 (My config: Zero-Installs, yarn dlx @yarnpkg/pnpify --sdk vscode).

Temporary workaround, add in .yarnrc.yml:

packageExtensions:
  eslint-plugin-sort-keys-fix@*:
    dependencies:
      requireindex: "~1.2.0"
      espree: "^6.1.2"
      esutils: "^2.0.2"
      natural-compare: "^1.4.0"

I'm adding dependencies that are being require'd in the codebase, but not defined in `package.json`. This issue is detected by Yarn 2 (My config: Zero-Installs, `yarn dlx @yarnpkg/pnpify --sdk vscode`).

Temporary workaround, add in `.yarnrc.yml`:
```
packageExtensions:
  eslint-plugin-sort-keys-fix@*:
    dependencies:
      requireindex: "~1.2.0"
      espree: "^6.1.2"
      esutils: "^2.0.2"
      natural-compare: "^1.4.0"

```
@lensbart
Copy link

@leo-buneev Any chance this could get merged and published? The change doesn’t impact code functionality. Thanks!

@leo-buneev
Copy link
Owner

Thank you! Apologies for such a long delay.

@leo-buneev leo-buneev merged commit 9787223 into leo-buneev:master Aug 2, 2021
@bitboxx bitboxx deleted the patch-1 branch October 1, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants