Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name all the dependencies this plugin depends on in package.json #25

Closed
lensbart opened this issue Apr 10, 2021 · 3 comments
Closed

Name all the dependencies this plugin depends on in package.json #25

lensbart opened this issue Apr 10, 2021 · 3 comments

Comments

@lensbart
Copy link

lensbart commented Apr 10, 2021

Yarn 2 is a bit more strict in its module resolution requirements. In particular, it requires that all dependencies consumed by a module are mentioned in its package.json.

eslint-plugin-sort-keys-fix violates this requirement by not listing espree, esutils or natural-compare in its dependencies. A simple fix would be to list these dependencies.

When using the ESLint VSCode plugin, the plugin won’t run unless the following is supplied in .yarnrc.yml as a temporary fix:

packageExtensions:
  # awaiting fix: https://github.com/leo-buneev/eslint-plugin-sort-keys-fix/issues/25
  eslint-plugin-sort-keys-fix@*:
    dependencies:
      espree: '*'
      esutils: '*'
      natural-compare: '*'
@Stephen2
Copy link

Stephen2 commented Jul 3, 2021

Thanks for listing the workaround. I guess I can put up a PR if there isn't one already

@Stephen2
Copy link

Stephen2 commented Jul 3, 2021

Damn, looks like we already have one: #23 but the maintainer isn't active

@leo-buneev
Copy link
Owner

leo-buneev commented Aug 2, 2021

Fixed in #23, apologies for delay everyone.
Released in 1.1.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants