Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot see full entry description #117

Closed
lemon24 opened this issue Jun 15, 2019 · 3 comments
Closed

Cannot see full entry description #117

lemon24 opened this issue Jun 15, 2019 · 3 comments
Labels

Comments

@lemon24
Copy link
Owner

lemon24 commented Jun 15, 2019

There are entries whose link points to content on another site, and that have a different description than the actual content. The only way to see the description is by looking at the feed; there should be a way to see it from the web UI.

@lemon24 lemon24 changed the title Cannot see full empty description Cannot see full entry description Jun 15, 2019
@lemon24
Copy link
Owner Author

lemon24 commented Jun 17, 2019

Currently the app is using the striptags filter to sanitize the content, but this results in the whole entry being a single paragraph.

Feedparser comes with its own sanitization, which we are using, since it's the default (we should make it explicit, though).

lemon24 added a commit that referenced this issue Jun 26, 2019
@lemon24
Copy link
Owner Author

lemon24 commented Jun 26, 2019

{# TODO: Also show summary. #}
{# TODO: text/plain loses formatting. #}
{# TODO: This allows iframes to show; is it safe? #}
{# TODO: This should be styled somehow. #}
{# TODO: h1 inside article is as big as the h1 in the header. #}
{# TODO: Images are too wide. #}

@lemon24 lemon24 assigned lemon24 and unassigned lemon24 Jun 26, 2019
lemon24 added a commit that referenced this issue Jun 29, 2019
lemon24 added a commit that referenced this issue Aug 14, 2019
lemon24 added a commit that referenced this issue Aug 14, 2019
@lemon24
Copy link
Owner Author

lemon24 commented Oct 12, 2021

Most of the comments are fixed.

The iframes stuff will be fixed by better sanitization.

The summary will be fixed by #130.

@lemon24 lemon24 closed this as completed Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant