Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace RealQuantity with Unitful.RealOrRealQuantity #7

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Replace RealQuantity with Unitful.RealOrRealQuantity #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa30b68
Replace `RealQuantity` with `Unitful.RealOrRealQuantity`
fhagemann Sep 11, 2024
fb6fe50
Set `compat` of Unitful to 1.6
fhagemann Sep 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ ProgressMeter = "1"
PropertyFunctions = "0.2.1"
StructArrays = "0.4, 0.5, 0.6"
Tables = "1"
Unitful = "1"
Unitful = "1.6"
julia = "1.9"
5 changes: 1 addition & 4 deletions src/LegendEventAnalysis.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,9 @@ using ProgressMeter: @showprogress
using PropertyFunctions: PropertyFunction, @pf, filterby

using Tables: columns

using Unitful: RealOrRealQuantity as RealQuantity
using LegendDataTypes: fast_flatten

# ToDo: Add this to LegendDataTypes:
const MaybeWithUnits{T<:Number} = Union{T,Quantity{<:T}}
const RealQuantity = MaybeWithUnits{<:Real}

include("flatten_over_channels.jl")
include("build_global_events.jl")
Expand Down