Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace RealQuantity with Unitful.RealOrRealQuantity #7

Merged
merged 2 commits into from
Sep 11, 2024

Conversation

fhagemann
Copy link
Contributor

Removes MaybeWithUnits, which was neither exported nor used in the package.

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.41%. Comparing base (e3e0a7d) to head (fb6fe50).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #7   +/-   ##
=======================================
  Coverage   10.41%   10.41%           
=======================================
  Files           7        7           
  Lines         192      192           
=======================================
  Hits           20       20           
  Misses        172      172           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oschulz oschulz merged commit b4e1d79 into legend-exp:main Sep 11, 2024
9 checks passed
@fhagemann fhagemann deleted the RealQuantity branch September 11, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants