-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CGI:cookie subroutine does not pass max-age to CGI::Cookie->new #247
Comments
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this issue
Jul 12, 2021
4.53 2021-06-03 [ FIX ] - fix typo in passing of max-age to CGI::Cookie (GH openembedded#247) 4.52 2021-05-04 [ FIX ] - sort hash keys for deterministic behaviour (GH openembedded#245, GH openembedded#246) References: leejo/CGI.pm#247 leejo/CGI.pm#246 leejo/CGI.pm#245 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
kraj
pushed a commit
to YoeDistro/meta-openembedded
that referenced
this issue
Jul 13, 2021
4.53 2021-06-03 [ FIX ] - fix typo in passing of max-age to CGI::Cookie (GH openembedded#247) 4.52 2021-05-04 [ FIX ] - sort hash keys for deterministic behaviour (GH openembedded#245, GH openembedded#246) References: leejo/CGI.pm#247 leejo/CGI.pm#246 leejo/CGI.pm#245 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
sgunin
pushed a commit
to sgunin/oe-meta-openembedded-contrib
that referenced
this issue
Mar 17, 2024
4.53 2021-06-03 [ FIX ] - fix typo in passing of max-age to CGI::Cookie (GH #247) 4.52 2021-05-04 [ FIX ] - sort hash keys for deterministic behaviour (GH #245, GH #246) References: leejo/CGI.pm#247 leejo/CGI.pm#246 leejo/CGI.pm#245 Signed-off-by: Tim Orling <[email protected]>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this issue
May 22, 2024
4.53 2021-06-03 [ FIX ] - fix typo in passing of max-age to CGI::Cookie (GH #247) 4.52 2021-05-04 [ FIX ] - sort hash keys for deterministic behaviour (GH #245, GH #246) References: leejo/CGI.pm#247 leejo/CGI.pm#246 leejo/CGI.pm#245 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
daregit
pushed a commit
to daregit/yocto-combined
that referenced
this issue
May 22, 2024
4.53 2021-06-03 [ FIX ] - fix typo in passing of max-age to CGI::Cookie (GH #247) 4.52 2021-05-04 [ FIX ] - sort hash keys for deterministic behaviour (GH #245, GH #246) References: leejo/CGI.pm#247 leejo/CGI.pm#246 leejo/CGI.pm#245 Signed-off-by: Tim Orling <[email protected]> Signed-off-by: Khem Raj <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While using cookie() to create a cookie I noticed that max-age parameter was not passed correctly to CGI::Cookie. When reviewing CGI.pm code I noticed the following code in cookie subroutine (line 2796):
push(@param,'-max_age'=>$max_age) if $max_age;
That should be:
push(@param,'-max-age'=>$max_age) if $max_age;
The text was updated successfully, but these errors were encountered: