Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nondeterministic hash key ordering #245

Closed
epa opened this issue Mar 18, 2021 · 1 comment
Closed

Nondeterministic hash key ordering #245

epa opened this issue Mar 18, 2021 · 1 comment
Assignees
@leejo

Comments

@epa
Copy link

epa commented Mar 18, 2021

The CGI.pm code in many places iterates over hash keys without sorting them. Newer perl versions deliberately give a nondeterministic ordering of hash keys. This means that CGI.pm has nondeterministic observable behaviour. The fix is to use sort keys instead of keys.
@epa epa mentioned this issue Mar 18, 2021
Merged
@leejo
Copy link
Owner

leejo commented Mar 18, 2021

Arguably in most places here it doesn't matter due to it being internal, and clearly nothing is testing these given the tests would have broken long ago. Nontheless I'll get #246 merged and uploaded shortly. Cheers!

@leejo leejo self-assigned this Mar 18, 2021
@leejo leejo closed this as completed in bee0f06 May 4, 2021
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 12, 2021
@moto-timo @kraj
libcgi-perl: upgrade 4.51 -> 4.53
c994027 
4.53 2021-06-03

    [ FIX ]
    - fix typo in passing of max-age to CGI::Cookie (GH openembedded#247)

4.52 2021-05-04

    [ FIX ]
    - sort hash keys for deterministic behaviour (GH openembedded#245, GH openembedded#246)

References:
leejo/CGI.pm#247
leejo/CGI.pm#246
leejo/CGI.pm#245

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
kraj pushed a commit to YoeDistro/meta-openembedded that referenced this issue Jul 13, 2021
@moto-timo @kraj
libcgi-perl: upgrade 4.51 -> 4.53
00923db 
4.53 2021-06-03

    [ FIX ]
    - fix typo in passing of max-age to CGI::Cookie (GH openembedded#247)

4.52 2021-05-04

    [ FIX ]
    - sort hash keys for deterministic behaviour (GH openembedded#245, GH openembedded#246)

References:
leejo/CGI.pm#247
leejo/CGI.pm#246
leejo/CGI.pm#245

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
sgunin pushed a commit to sgunin/oe-meta-openembedded-contrib that referenced this issue Mar 17, 2024
libcgi-perl: upgrade 4.51 -> 4.53
8ca0479 
4.53 2021-06-03

    [ FIX ]
    - fix typo in passing of max-age to CGI::Cookie (GH #247)

4.52 2021-05-04

    [ FIX ]
    - sort hash keys for deterministic behaviour (GH #245, GH #246)

References:
leejo/CGI.pm#247
leejo/CGI.pm#246
leejo/CGI.pm#245

Signed-off-by: Tim Orling <[email protected]>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@moto-timo @kraj
src/meta-openembedded:libcgi-perl: upgrade 4.51 -> 4.53
37f2f0c 
4.53 2021-06-03

    [ FIX ]
    - fix typo in passing of max-age to CGI::Cookie (GH #247)

4.52 2021-05-04

    [ FIX ]
    - sort hash keys for deterministic behaviour (GH #245, GH #246)

References:
leejo/CGI.pm#247
leejo/CGI.pm#246
leejo/CGI.pm#245

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
daregit pushed a commit to daregit/yocto-combined that referenced this issue May 22, 2024
@moto-timo @kraj
src/meta-openembedded:libcgi-perl: upgrade 4.51 -> 4.53
a06c8e1 
4.53 2021-06-03

    [ FIX ]
    - fix typo in passing of max-age to CGI::Cookie (GH #247)

4.52 2021-05-04

    [ FIX ]
    - sort hash keys for deterministic behaviour (GH #245, GH #246)

References:
leejo/CGI.pm#247
leejo/CGI.pm#246
leejo/CGI.pm#245

Signed-off-by: Tim Orling <[email protected]>
Signed-off-by: Khem Raj <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leejo leejo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epa @leejo