-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic alphabetic sort option to topic tree #4423
Add automatic alphabetic sort option to topic tree #4423
Conversation
@bjester Quick question . How should I handle translations in different languages for this new feature, with the inclusion of the associated icon? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far. Mostly on the right track, but I left some details comments on things that need addressed.
contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
Outdated
Show resolved
Hide resolved
contentcuration/contentcuration/frontend/channelEdit/views/CurrentTopicView.vue
Outdated
Show resolved
Hide resolved
The process of translating strings is taken care of in bulk when we proceed with a new release of Studio. I added a comment regarding where you can add a new string for the linting error observed |
@bjester, I've implemented all the recommended changes. I just need clarification regarding the icon. In the case of Icon tag for using an SVG, there is a Vue component-based system and cutom icon addition, but for the IconButton, I haven't found a similar approach. Could you provide guidance on how to add an SVG to the IconButton, or should I consider an alternative method for this? |
@GarvitSinghal47 To make it easy, lets just use this icon, |
@GarvitSinghal47 Just wanted to say thank you for implementing this. I'll be reviewing it soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work @GarvitSinghal47! I merged our unstable
branch in and updated the buttons to use KIconButton
so now it has the proper icon. Thank you
Fixes #1830
Summary
Description of the change(s) you made
This pull request introduces a new feature - an automatic alphabetic sort option for the topic tree. When the designated button is clicked, the selected nodes will be reordered based on their alphabetic order. To achieve this, the Vuex action moveContentNodes is utilized for processing the reordering.
Manual verification steps performed
Screenshots (if applicable)
Untitled.-.Imported.Channel.-.Kolibri.Studio.mp4
Does this introduce any tech-debt items?
Reviewer guidance
How can a reviewer test these changes?
Are there any risky areas that deserve extra testing?
References
Comments
Contributor's Checklist
PR process:
CHANGELOG
label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later timedocs
label has been added if this introduces a change that needs to be updated in the user docs?requirements.txt
files also included in this PRStudio-specifc:
notranslate
class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)pages
,components
, andlayouts
directories as described in the docsTesting:
Reviewer's Checklist
This section is for reviewers to fill out.
yarn
andpip
)