Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 'sort alphabetically' button icon #4426

Closed
bjester opened this issue Feb 2, 2024 · 4 comments
Closed

Replace 'sort alphabetically' button icon #4426

bjester opened this issue Feb 2, 2024 · 4 comments
Assignees
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression TAG: design system

Comments

@bjester
Copy link
Member

bjester commented Feb 2, 2024

Observed behavior

To avoid blocking a contributor, we used a temporary icon for a button implementing new functionality.

Expected behavior

We need this icon added to KDS and KDS updated here to use the new icon.
sort

User-facing consequences

We shouldn't release until we've either hidden that button or updated the icon.

@bjester bjester added the P0 - critical Priority: Release blocker or regression label Feb 2, 2024
@bjester bjester added this to the Studio: Q1-24 Patch milestone Feb 2, 2024
@FidalMathew
Copy link
Contributor

Hi @bjester Can I work on this issue?

@MisRob
Copy link
Member

MisRob commented Feb 5, 2024

Hi @FidalMathew, I already have this in progress, together with writing guidance for KDS repository on adding new icons. So I will do this one. Thank you!

@bjester
Copy link
Member Author

bjester commented Apr 9, 2024

@MisRob Sorry I forgot we added this issue. This should be completed by a commit I pushed to the contributor's PR, but if you wanted to verify it's properly handled, I think that would okay :)

@MisRob
Copy link
Member

MisRob commented Apr 9, 2024

Thank you @bjester

@MisRob MisRob closed this as completed Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: frontend P0 - critical Priority: Release blocker or regression TAG: design system
Projects
None yet
Development

No branches or pull requests

3 participants