Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate logout to all open tabs #3988

Merged
merged 1 commit into from
Mar 15, 2023
Merged

Propagate logout to all open tabs #3988

merged 1 commit into from
Mar 15, 2023

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • Move resource listener registration to run in all tabs, not just the leader tab.
  • This was preventing the logout listener being triggered in all open tabs

Manual verification steps performed

  1. Run Studio.
  2. Login.
  3. Open another tab.
  4. Logout in one tab - confirm that it redirects to the account page in every tab.

Fixes #3915

@rtibbles rtibbles added this to the Studio: next major release milestone Mar 15, 2023
@rtibbles rtibbles requested a review from bjester March 15, 2023 03:25
bjester
bjester approved these changes Mar 15, 2023
View reviewed changes
Copy link
Member

@bjester bjester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this makes total sense

@bjester bjester merged commit db36b2f into learningequality:unstable Mar 15, 2023
@bjester bjester mentioned this pull request May 3, 2023
Merged
@bjester bjester mentioned this pull request Jul 5, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjester bjester bjester approved these changes

Assignees
No one assigned
Labels
TODO: needs review
Projects
None yet
Milestone
Studio: Q2 2023 Release
Development

Successfully merging this pull request may close these issues.

Missing indication that I am signed out
2 participants
@rtibbles @bjester