Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing indication that I am signed out #3915

Closed
pcenov opened this issue Jan 23, 2023 · 4 comments · Fixed by #3988
Closed

Missing indication that I am signed out #3915

pcenov opened this issue Jan 23, 2023 · 4 comments · Fixed by #3988
Assignees
Labels

Comments

@pcenov
Copy link
Member

pcenov commented Jan 23, 2023

Observed behavior

If I am using Studio in several browser windows, when I sign out in one of the windows then I am not prompted to refresh the page in the other windows and this can be confusing.

Expected behavior

The expected behavior should be further discussed.

Steps to reproduce the issue

  1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
  2. Duplicate the browser window and sign out in one of the windows
  3. Keep browsing in the other window

Additional information

Videos:

2023-01-23_17-55-49.mp4
2023-01-23_18-01-47.mp4

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Jan 23, 2023

@radinamatic

@bjester
Copy link
Member

bjester commented Jan 24, 2023

I believe this bit of code is supposed to react to authentication changes, and reload to the accounts page but it seems that may not be happening.

@marsian83
Copy link
Contributor

I was wondering if this if statement

could be omitted entirely as we are only executing it after there is a change in the auth state
I was seriously wondering if the check is even necessary

@bjester
Copy link
Member

bjester commented Jan 31, 2023

@marsian83 In the attached videos, it doesn't seem that the referenced if statement would block the page reload. Have you been able to reproduce the issue in your local development environment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants