Ensure changes get properly cleared as succeeded and make refresh blocking more targeted #3789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Description of the change(s) you made
Manual verification steps performed
_clone_node
method of theCustomContentNodeTreeManager
to make copies run slowly to replicate the error from productionimport from channels
modal, to ensure two copy operations are startedScreenshots (if applicable)
Screencast.from.11-02-2022.02.54.48.PM.webm.mp4
Does this introduce any tech-debt items?
I think this can be done much more neatly and efficiently with the websockets work!
Reviewer guidance
How can a reviewer test these changes?
Do the manual steps suggested above.
Review the new logic for more targeted refresh blocking - does this miss any cases?
References
Fixes #3753