Hotfixes - Import from channels - Folder contents are not always displayed without having to sign out first

[pcenov]

Observed behavior

After importing a folder with subfolders from Khan Academy I'm not able to see the contents of the folder. I tried refreshing and going back to the channels page but only signing out and signing in seems to do the trick.

Expected behavior

Imported folders with resources should be fully visible

Steps to reproduce the issue

1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
2. Create a new channel and import a folder with subfolders from Khan Academy
3. Attempt to view the imported resources

Additional information

2022-10-19_16-43-00.mp4

Usage Details

• OS: Windows 10
• Browser: Chrome
• URL: https://hotfixes.studio.learningequality.org/

[pcenov]

@bjester and @radinamatic

[bjester]

@rtibbles I was able to reproduce this on the hotfixes server, but I haven't been able to locally. I tried both the 'Import from channels' flow and via the clipboard. Neither importing a folder of folders nor a folder of only resources seemed to help locally. 🙁

[rtibbles]

This seems to be happening because the copy change is not getting set as applied/cleared once the copy operation has completed. This means that we then are preventing all HTTP requests while the change hasn't been applied.

[rtibbles]

This seems to be stemming from a bug in the max channel revision calculation logic. The change returned to the frontend to propagate the task association has a higher server revision than the copy change. This causes the frontend to return this higher revision as the last seen revision, and so does not return the success status for the copy change.

[marcellamaki]

Should be updated with #3771 and ready for testing on hotfixes. will wait for confirmation that it is also working on hotfixes before closing

[rtibbles]

Neither @radinamatic nor myself can now replicate this on hotfixes.

[rtibbles]

This issue seems to appear after multiple copy events have taken place in a channel. I suspect the max revs are being improperly set still, so we should side step these for checking on whether a change has been successfully applied.

[rtibbles]

Should really be fixed in #3789

[radinamatic]

Looking good, several tests with simultaneous imports of 2 up to 6 folders were successful with all the subfolders visible! 💯 🎉