Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 3208: welcome new user email feature added #3405

Merged
merged 7 commits into from
Aug 2, 2022

Conversation

bjester
Copy link
Member

@bjester bjester commented Jun 7, 2022

Summary

Adds new registration welcome email.

Description of the change(s) you made

  • Originally started by @vishalpandeyvip
  • Updates all translations in templates to use newly documented {% translate ... instead of {% trans ...

Manual verification steps performed

  1. Ran the devserver with SEND_USER_ACTIVATION_NOTIFICATION_EMAIL=1 env variable
  2. Created a new account
  3. Followed activation link
  4. Extracted the email html and viewed it in a web browser

Screenshots (if applicable)

Browser screenshot:
Screenshot from 2022-08-02 10-47-05

References

#3305

Comments


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@bjester bjester linked an issue Jun 7, 2022 that may be closed by this pull request
@bjester bjester marked this pull request as ready for review August 2, 2022 17:35
Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes in strings per se, a part from the new ones in the welcome email, just the trans > translate, so seems good to go! 👏🏽 :shipit:

@bjester bjester merged commit 613e216 into learningequality:unstable Aug 2, 2022
@pcenov
Copy link
Member

pcenov commented Sep 20, 2022

I am receiving the email successfully but I noticed the following issues:

  1. The first couple of links are not working/broken.
  2. There is no spacing between the paragraphs.

2022-09-20_17-25-57

@bjester
Copy link
Member Author

bjester commented Sep 20, 2022

@pcenov Could you forward the email to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kolibri Studio welcome e-mail with documentation links
4 participants