Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 3208: welcome new user email feature added #3305

Closed
wants to merge 4 commits into from
Closed

issue 3208: welcome new user email feature added #3305

wants to merge 4 commits into from

Conversation

vishalpandeynits
Copy link
Contributor

@vishalpandeynits vishalpandeynits commented Nov 24, 2021

This PR adds the feature that whenever a user registers and its activation is completed,
a welcome email will be sent to him describing the Kolibri features and it also has different tutorial links
The email template was provided in the issue #3208 .

#Screenshot
Email message

@vishalpandeynits
Copy link
Contributor Author

cc @rtibbles

@lauradanforth
Copy link

@vishalpandeyvip Thank you again for your support on this. Could you make a few small tweaks on this for us?:

  • Remove the "Hello ," at the beginning
  • Change the banner at the top to "Welcome to Kolibri Studio" (remove 'the')
  • Put the following items in bold face: "Kolibri Studio User Guide" "Content integration guide" and "Step by step tutorials"
  • Capitalize the 'E' in English at the end: "*Resources are presented in English"

Thank you so much! Looking forward to getting this in.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vishalpandeynits
Copy link
Contributor Author

Thanks for your review @lauradanforth, I have made the changes requested by you. Here is the new screenshot of the email
Screenshot from 2021-12-20 22-18-00
.

Copy link

@lauradanforth lauradanforth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @vishalpandeyvip thank you!

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bjester
Copy link
Member

bjester commented Jan 28, 2022

@vishalpandeyvip Thank you for working on this issue! I made a couple updates to it, but I checked with @lauradanforth and we also need to allow this email to be translatable. We're making tweaks to the copy now to resolve some issues in conflict with making it translatable. There are examples of how we set this up in other emails like the activation email referenced in the issue, if you would like to make these further updates?

@lauradanforth
Copy link

@bjester I updated the draft here with included links listed out, to support this being translated

@lauradanforth
Copy link

Updated again - hopefully correctly this time! Lmk if it's still off.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants