Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load portuguese country name data for country listing #3176

Merged
merged 1 commit into from
May 27, 2021

Conversation

rtibbles
Copy link
Member

Summary

Description of the change(s) you made

  • We currently get country name data from the countries npm package
  • We specifically load the data for each supported locale
  • We had not updated this for Portuguese

Manual verification steps performed

  1. Create an account
  2. Check that the countries are actually listed

Screenshots (if applicable)

Screenshot from 2021-05-27 10-32-04

Does this introduce any tech-debt items?


Reviewer guidance

How can a reviewer test these changes?

Are there any risky areas that deserve extra testing?

References

Fixes #3167

Comments

A follow up issue is filed here to address the implementation details that caused this bug.


Contributor's Checklist

PR process:

  • If this is an important user-facing change, PR or related issue the CHANGELOG label been added to this PR. Note: items with this label will be added to the CHANGELOG at a later time
  • If this includes an internal dependency change, a link to the diff is provided
  • The docs label has been added if this introduces a change that needs to be updated in the user docs?
  • If any Python requirements have changed, the updated requirements.txt files also included in this PR
  • Opportunities for using Google Analytics here are noted
  • Migrations are safe for a large db

Studio-specifc:

  • All user-facing strings are translated properly
  • The notranslate class been added to elements that shouldn't be translated by Google Chrome's automatic translation feature (e.g. icons, user-generated text)
  • All UI components are LTR and RTL compliant
  • Views are organized into pages, components, and layouts directories as described in the docs
  • Users' storage used is recalculated properly on any changes to main tree files
  • If there new ways this uses user data that needs to be factored into our Privacy Policy, it has been noted.

Testing:

  • Code is clean and well-commented
  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Any new interactions have been added to the QA Sheet
  • Critical and brittle code paths are covered by unit tests

Reviewer's Checklist

This section is for reviewers to fill out.

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles linked an issue May 27, 2021 that may be closed by this pull request
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Manual QA of this looks good to me. And thank you for fixing a problem that I caused 😄

@rtibbles
Copy link
Member Author

You were necessary, but not sufficient for this bug to occur, so to say you caused it might be an overstatement.

Even then, your involvement as the person who added Portuguese was entirely contingent.

@rtibbles rtibbles merged commit c74f131 into learningequality:hotfixes May 27, 2021
@rtibbles rtibbles deleted the country_list branch May 27, 2021 17:55
@pcenov
Copy link
Member

pcenov commented May 28, 2021

Tested and verified as fixed at https://hotfixes.studio.learningequality.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Country list not available in PT-BR locale
3 participants