Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build the labels with their ids from a template #92

Merged
merged 8 commits into from
Oct 5, 2021
Merged

Build the labels with their ids from a template #92

merged 8 commits into from
Oct 5, 2021

Conversation

jredrejo
Copy link
Member

Builds a json file that can be used from JavaScript to have a complete list of the LE labels, according to https://docs.google.com/spreadsheets/d/16m_ELq6-hmBgveV3YJ6e_q0YmCRB0av2K22er_nEQuk/edit

As labels are not stored in a DB table, there's no need to create the mapper for python constants.

It would be good to decide if this is the best way to provide the list for the frontend or a generator for it should be added to kolibri/studio so a format closer to https://github.com/learningequality/kolibri/blob/develop/kolibri/core/assets/src/constants.js#L34 is available.

@jredrejo jredrejo requested a review from rtibbles September 23, 2021 19:06
@jredrejo jredrejo changed the title Build the labels withs their ids from a template Build the labels with their ids from a template Sep 23, 2021
CHANGELOG.md Outdated Show resolved Hide resolved
@rtibbles rtibbles merged commit 1738c9b into master Oct 5, 2021
@rtibbles rtibbles deleted the labels branch October 5, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants