Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial constants integration. #8478

Merged
merged 2 commits into from
Oct 5, 2021
Merged

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Oct 4, 2021

Summary

  • Integrates standard JS constants for new metadata labels

References

Integration of JS package from this PR:
learningequality/le-utils#92

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from marcellamaki October 4, 2021 20:12
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good and like it should handle the constants changes well in the front end

Make jest transpile it.
@rtibbles rtibbles marked this pull request as ready for review October 5, 2021 20:04
@rtibbles rtibbles merged commit 352329a into learningequality:develop Oct 5, 2021
@rtibbles rtibbles deleted the constants branch October 5, 2021 20:49
Comment on lines +8846 to +8855
[email protected]:
version "0.1.32"
resolved "https://registry.yarnpkg.com/kolibri-constants/-/kolibri-constants-0.1.32.tgz#852306cfa84c249db4748584d9c4a4fdad1a560a"
integrity sha512-YXvbBSEogO7hSE4wfKUqcJcj/y0kGtyxa4ECPJgoby+GxlFoiBZlWmfYaSansp+Cd1oScBvL8vYaeU5C8dKVXA==

kolibri-constants@^0.1.32-beta1:
version "0.1.32-beta1"
resolved "https://registry.yarnpkg.com/kolibri-constants/-/kolibri-constants-0.1.32-beta1.tgz#6bee6ecba1e451930494bef5b4fde60ef9246cc9"
integrity sha512-D9UBe5Nj2VDgdrpCUWhvXn1Lef7gF1kzSH5rvbKMzVTwaGo5qi5VgBPen3vyJ4VjN01zZkOO3kn1QJjK5NLxSg==

Copy link
Contributor

@indirectlylit indirectlylit Oct 14, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we appear to have two versions possibly because of an out-of-date kolibri-core-for-export (kolibri/core/package.json)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants