Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Introduce KDS breadcrumbs fixes #8972

Closed
wants to merge 1 commit into from

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Dec 31, 2021

Summary

Pins KDS to learningequality/kolibri-design-system#292.

Do not merge. The temporary commit will be replaced by the new KDS release tag as soon as the first reviews are completed.

References

Resolves #6918

Reviewer guidance

See testing instructions in learningequality/kolibri-design-system#292.

There's no need to use yarn link locally to test KDS updates in Kolibri since this PR contains a commit that temporarily pins the corresponding KDS commit for testing. You only need to run yarn install to update dependencies after checking out this PR's branch.

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@MisRob MisRob added the TODO: needs review Waiting for review label Dec 31, 2021
@MisRob MisRob changed the title Introduce KDS breadcrumbs fixes [DO NOT MERGE] Introduce KDS breadcrumbs fixes Dec 31, 2021
@MisRob MisRob added this to the 0.15.1 milestone Jan 3, 2022
@MisRob MisRob added bug Behavior is wrong or broken DEV: frontend labels Jan 3, 2022
@MisRob
Copy link
Member Author

MisRob commented Jan 4, 2022

This needs to be retargeted to release-0.15.x. Will do soon. Done

@MisRob MisRob changed the base branch from develop to release-v0.15.x January 5, 2022 12:25
@MisRob
Copy link
Member Author

MisRob commented Jan 6, 2022

I force-pushed the last commit with no updates to trigger staling checks.

@MisRob
Copy link
Member Author

MisRob commented Jan 24, 2022

Closing as this was only for testing

@MisRob MisRob closed this Jan 24, 2022
@MisRob MisRob mentioned this pull request Jan 25, 2022
9 tasks
@MisRob MisRob deleted the kbreadcrumbs branch January 25, 2022 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Behavior is wrong or broken DEV: frontend TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long channel names truncated in two UI components
1 participant