Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Long channel names truncated in two UI components #6918

Closed
ivanistheone opened this issue May 22, 2020 · 1 comment · Fixed by learningequality/kolibri-design-system#292 or #9036
Closed

Long channel names truncated in two UI components #6918

ivanistheone opened this issue May 22, 2020 · 1 comment · Fixed by learningequality/kolibri-design-system#292 or #9036
Assignees
@MisRob
Labels
P2 - normal Priority: Nice to have TAG: design system Change to our style guide / design system
Milestone
upcoming patch

Comments

@ivanistheone
Copy link
Contributor

Observed behavior

I have a feeling these are both part of the same bredcumbs component, so reporitng together.

  1. During channel import, the channel name above the select content component is cutoff:

WHY CUTOFF

  1. Also gets cut off in breadcrumbs:
    Screen Shot 2020-05-22 at 11 31 31 AM

Expected behavior

I would have expected to see the complete channel name in those places, given there is room for it.

Possible fix

Perhaps it is possible for the breadcumb component not to apply the max-width property for the last item in the list?
@indirectlylit indirectlylit changed the title Long channel names cutoff in two UI components Long channel names truncated in two UI components May 23, 2020
@indirectlylit indirectlylit added DEV: frontend P2 - normal Priority: Nice to have TAG: ux update Improved user-facing feature labels May 23, 2020
@indirectlylit indirectlylit added this to the upcoming patch milestone May 23, 2020
@davidgarg20 davidgarg20 mentioned this issue Mar 15, 2021
Closed
9 tasks
@jonboiser jonboiser added TAG: design system Change to our style guide / design system and removed TAG: beginner friendly TAG: ux update Improved user-facing feature labels Mar 18, 2021
@jonboiser jonboiser mentioned this issue Mar 18, 2021
Closed
MisRob added a commit to MisRob/kolibri-design-system that referenced this issue Dec 27, 2021
@MisRob
Do not truncate the last item
15375ba 
when breadcrumbs are not collapsed
to allow them use all space available

Fixes learningequality#198
Fixes learningequality/kolibri#6918
MisRob added a commit to MisRob/kolibri-design-system that referenced this issue Dec 29, 2021
@MisRob
Do not truncate the last breadcrumb item
8f4fe50 
when not necessary

Fixes learningequality#198
Fixes learningequality/kolibri#6918
MisRob added a commit to MisRob/kolibri-design-system that referenced this issue Dec 29, 2021
@MisRob
Do not truncate the last breadcrumb item
f8c095f 
when not necessary

Fixes learningequality#198
Fixes learningequality/kolibri#6918
This was referenced Dec 31, 2021
Merged
Closed
@MisRob
Copy link
Member

MisRob commented Jan 24, 2022

Re-opening since this will be fixed after we install the new version of KDS which hasn't happened yet

@MisRob MisRob reopened this Jan 24, 2022
@MisRob MisRob self-assigned this Jan 24, 2022
@MisRob MisRob mentioned this issue Jan 25, 2022
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MisRob MisRob

Labels
P2 - normal Priority: Nice to have TAG: design system Change to our style guide / design system
Projects
None yet
Milestone
upcoming patch
4 participants
@ivanistheone @indirectlylit @jonboiser @MisRob