-
Notifications
You must be signed in to change notification settings - Fork 730
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Strings with some feature dev for Channel browse and search #8424
Merged
rtibbles
merged 19 commits into
learningequality:develop
from
marcellamaki:channel-browse-and-search
Sep 15, 2021
Merged
WIP: Strings with some feature dev for Channel browse and search #8424
rtibbles
merged 19 commits into
learningequality:develop
from
marcellamaki:channel-browse-and-search
Sep 15, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st pass UI for side panel.
…d update files with new helper
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 13, 2021
kolibri/plugins/learn/assets/src/views/ContentCardListViewItem.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Sep 13, 2021
kolibri/plugins/learn/assets/src/views/ContentCardListViewItem.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Sep 13, 2021
kolibri/plugins/learn/assets/src/views/ContentCardListViewItem.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Sep 13, 2021
kolibri/plugins/learn/assets/src/views/EmbeddedSidePanel/SelectGroup.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Sep 13, 2021
kolibri/plugins/learn/assets/src/views/EmbeddedSidePanel/SelectGroup.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Sep 13, 2021
kolibri/plugins/learn/assets/src/views/EmbeddedSidePanel/index.vue
Outdated
Show resolved
Hide resolved
radinamatic
reviewed
Sep 13, 2021
radinamatic
reviewed
Sep 14, 2021
radinamatic
reviewed
Sep 14, 2021
radinamatic
reviewed
Sep 14, 2021
radinamatic
reviewed
Sep 14, 2021
radinamatic
reviewed
Sep 14, 2021
radinamatic
reviewed
Sep 14, 2021
radinamatic
reviewed
Sep 14, 2021
I know it's a lot of comments, but we are merging this to get in the strings, so let's do them properly. Screencasts are such a teaser, great work, looking forward to seeing all this in action! 👏🏽 |
radinamatic
reviewed
Sep 14, 2021
rtibbles
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a WIP PR for Channel Browse and Search frontend. The main layout of the page has been updated, and there have been some design updates, but both refactoring/code cleanup and additional design smoothing out need to happen. The purpose of this PR at this time is to get all of the strings into the repo.
PR is not fully functional so please do not judge the code too harshly 😄
Related to feature development in #8304, #8305, #8306
NOTE: "Sidepanel" or "Info panel" related feature development and strings is in a separate PR that I will convert from draft tomorrow.
Reviewer Guidance
Are any strings in ditto or figma associated with these pages missing and not included anywhere else?
(note) When referencing Ditto, most of the strings in frames 1 - 10 are located within component code at the bottom of the page, and most of the strings referenced in frame 11 (related to categorical metadata) is located in commonCoreStrings.
Does it break anything we can't break right now?