Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Strings with some feature dev for Channel browse and search #8424

Merged

Conversation

marcellamaki
Copy link
Member

This is a WIP PR for Channel Browse and Search frontend. The main layout of the page has been updated, and there have been some design updates, but both refactoring/code cleanup and additional design smoothing out need to happen. The purpose of this PR at this time is to get all of the strings into the repo.

PR is not fully functional so please do not judge the code too harshly 😄

Related to feature development in #8304, #8305, #8306

NOTE: "Sidepanel" or "Info panel" related feature development and strings is in a separate PR that I will convert from draft tomorrow.

channel-browse-and-filter

channel-browse-wip

Reviewer Guidance

  1. Are any strings in ditto or figma associated with these pages missing and not included anywhere else?
    (note) When referencing Ditto, most of the strings in frames 1 - 10 are located within component code at the bottom of the page, and most of the strings referenced in frame 11 (related to categorical metadata) is located in commonCoreStrings.

  2. Does it break anything we can't break right now?

@radinamatic
Copy link
Member

I know it's a lot of comments, but we are merging this to get in the strings, so let's do them properly.

Screencasts are such a teaser, great work, looking forward to seeing all this in action! 👏🏽

@rtibbles rtibbles merged commit 80369e5 into learningequality:develop Sep 15, 2021
@marcellamaki marcellamaki mentioned this pull request Oct 22, 2021
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants