Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup errors from ContentNodeResource changes #8174

Merged
merged 1 commit into from
Jun 24, 2021

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jun 24, 2021

Summary

  • Properly receive parameters for fetchCollection method.
  • Return conditional promises for async methods.

References

Follow up from #8138

Reviewer guidance

Can a quiz be loaded for a learner?
Do topic trees properly load just the children of the parent, and not everything?


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Return conditional promises for async methods.
@rtibbles rtibbles added the TODO: needs review Waiting for review label Jun 24, 2021
@rtibbles rtibbles added this to the 0.15.0 milestone Jun 24, 2021
@rtibbles rtibbles requested a review from sairina June 24, 2021 18:24
Copy link
Contributor

@sairina sairina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes all the things!
image

@sairina sairina merged commit bf7bc84 into learningequality:develop Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants